You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/02 09:39:59 UTC
[GitHub] [skywalking] dmsolr commented on a change in pull request #4161:
add Dynamic Configuration Consul AclToken
dmsolr commented on a change in pull request #4161: add Dynamic Configuration Consul AclToken
URL: https://github.com/apache/skywalking/pull/4161#discussion_r362413572
##########
File path: oap-server/server-cluster-plugin/cluster-consul-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/consul/ClusterModuleConsulProvider.java
##########
@@ -76,6 +76,10 @@ public ClusterModuleConsulProvider() {
// we should set this value or it will be blocked forever
.withConnectTimeoutMillis(3000);
+ if (config.getAclToken() != null && !config.getAclToken().isEmpty()) {
Review comment:
Why do not you use `!Strings.isNullOrEmpty(config.getAclToken())`? I think that it is more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services