You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "JayajP (via GitHub)" <gi...@apache.org> on 2024/04/16 19:03:25 UTC
[PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
JayajP opened a new pull request, #31000:
URL: https://github.com/apache/beam/pull/31000
Use base 2 exponential histograms in BigQuerySinkMetrics. This shows better performance on load tests either because the bucket index computation is faster or because there are fewer buckets to send to DFE.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on PR #31000:
URL: https://github.com/apache/beam/pull/31000#issuecomment-2059851330
R: @m-trieu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on code in PR #31000:
URL: https://github.com/apache/beam/pull/31000#discussion_r1569127726
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java:
##########
@@ -106,15 +106,15 @@ static Counter createRPCRequestCounter(RpcMethod method, String rpcStatus, Strin
* <p>'RpcLatency-Method:{method};'
*
* @param method StorageWriteAPI method associated with this metric.
- * @return Histogram with exponential buckets with a sqrt(2) growth factor.
+ * @return Histogram with exponential buckets with a size 2 growth factor.
*/
static Histogram createRPCLatencyHistogram(RpcMethod method) {
LabeledMetricNameUtils.MetricNameBuilder nameBuilder =
LabeledMetricNameUtils.MetricNameBuilder.baseNameBuilder(RPC_LATENCY);
nameBuilder.addLabel(RPC_METHOD, method.toString());
MetricName metricName = nameBuilder.build(METRICS_NAMESPACE);
- HistogramData.BucketType buckets = HistogramData.ExponentialBuckets.of(1, 34);
+ HistogramData.BucketType buckets = HistogramData.ExponentialBuckets.of(0, 17);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
Posted by "m-trieu (via GitHub)" <gi...@apache.org>.
m-trieu commented on code in PR #31000:
URL: https://github.com/apache/beam/pull/31000#discussion_r1568308513
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java:
##########
@@ -106,15 +106,15 @@ static Counter createRPCRequestCounter(RpcMethod method, String rpcStatus, Strin
* <p>'RpcLatency-Method:{method};'
*
* @param method StorageWriteAPI method associated with this metric.
- * @return Histogram with exponential buckets with a sqrt(2) growth factor.
+ * @return Histogram with exponential buckets with a size 2 growth factor.
*/
static Histogram createRPCLatencyHistogram(RpcMethod method) {
LabeledMetricNameUtils.MetricNameBuilder nameBuilder =
LabeledMetricNameUtils.MetricNameBuilder.baseNameBuilder(RPC_LATENCY);
nameBuilder.addLabel(RPC_METHOD, method.toString());
MetricName metricName = nameBuilder.build(METRICS_NAMESPACE);
- HistogramData.BucketType buckets = HistogramData.ExponentialBuckets.of(1, 34);
+ HistogramData.BucketType buckets = HistogramData.ExponentialBuckets.of(0, 17);
Review Comment:
can you add a comment on what the 0 and 17 is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #31000:
URL: https://github.com/apache/beam/pull/31000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
Posted by "JayajP (via GitHub)" <gi...@apache.org>.
JayajP commented on PR #31000:
URL: https://github.com/apache/beam/pull/31000#issuecomment-2060296545
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31000:
URL: https://github.com/apache/beam/pull/31000#issuecomment-2059853042
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org