You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/09/26 07:07:16 UTC
[PR] [FLINK-36376] More friendly error or warn message for misconfigured statebackend with async state processing [flink]
Zakelly opened a new pull request, #25403:
URL: https://github.com/apache/flink/pull/25403
## What is the purpose of the change
We don't support state v1 when enabling async state processing, or state v2 when disabling async state processing. This PR gives user a more friendly error or warn message for it.
## Brief change log
- Error message when using wrong async operator with state api (api v1 with async processing, or api v2 without async processing).
- Warn message when using `AsyncKeyedStateBackendAdaptor`
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36376] More friendly error or warn message for misconfigured statebackend with async state processing [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25403:
URL: https://github.com/apache/flink/pull/25403#issuecomment-2376120736
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "947c5e75c9a2672792cbc7064af58fbfb1ef3429",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "947c5e75c9a2672792cbc7064af58fbfb1ef3429",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 947c5e75c9a2672792cbc7064af58fbfb1ef3429 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36376] More friendly error or warn message for misconfigured statebackend with async state processing [flink]
Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly commented on code in PR #25403:
URL: https://github.com/apache/flink/pull/25403#discussion_r1778286768
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java:
##########
@@ -110,6 +112,8 @@ public StreamingRuntimeContext(
this.operatorUniqueID = checkNotNull(operatorID).toString();
this.processingTimeService = processingTimeService;
this.keyedStateStore = keyedStateStore;
+ // By default, support state v1
+ this.supportKeyedStateApiSet = SupportKeyedStateApiSet.STATE_V1;
Review Comment:
Well I'd rather not. In some test they does not call `setKeyedStateStore` but the `keyedStateStore` is set in constructor, I'd keep those tests unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36376] More friendly error or warn message for misconfigured statebackend with async state processing [flink]
Posted by "fredia (via GitHub)" <gi...@apache.org>.
fredia commented on code in PR #25403:
URL: https://github.com/apache/flink/pull/25403#discussion_r1778284554
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java:
##########
@@ -110,6 +112,8 @@ public StreamingRuntimeContext(
this.operatorUniqueID = checkNotNull(operatorID).toString();
this.processingTimeService = processingTimeService;
this.keyedStateStore = keyedStateStore;
+ // By default, support state v1
+ this.supportKeyedStateApiSet = SupportKeyedStateApiSet.STATE_V1;
Review Comment:
nit: set `supportKeyedStateApiSet=V1` in `setKeyedStateStore(@Nullable KeyedStateStore keyedStateStore)` instead of here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org