[GitHub] sijie opened a new pull request #1172: Use BookieServer#getLocalAddress as the identifier in the test

[GitBox <gi...@apache.org>]

sijie opened a new pull request #1172: Use BookieServer#getLocalAddress as the identifier in the test
URL: https://github.com/apache/bookkeeper/pull/1172
 
 
   Descriptions of the changes in this PR:
   
   *Problem*
   
   Issue #1097 introduced using `loopback` nic as the bookie server identifier. However a few test cases construct the bookie socket address using `InetAddress.getLocalHost()` and the bookie port. This bookie socket address can be different from the actual socket address that a bookie is advertising to zookeeper. It will cause test cases fail with certain network settings.
   
   *Solution*
   
   This change use `BookieServer#getLocalAddress()` to retrieve the actual bookie socket address. so it would respect to the server configuration and use the right socket address in the test.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services