You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/08/02 00:53:38 UTC
Review Request 61288: Linked `libprocess` to `stout` interface
library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61288/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Linked `libprocess` to `stout` interface library.
Diffs
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 3e621f97b683012beca5705fbf3e4000d686f3ab
3rdparty/libprocess/cmake/ProcessConfigure.cmake 75af774e1460319cef1efdf801eb97f34eada0e7
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 5a23990825de04f27bd5f74c82e10b702974f875
3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d
Diff: https://reviews.apache.org/r/61288/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 61288: Linked `libprocess` to `stout` interface
library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61288/#review182353
-----------------------------------------------------------
3rdparty/libprocess/src/CMakeLists.txt
Line 115 (original)
<https://reviews.apache.org/r/61288/#comment258226>
Note to self: If there is a review later in the chain that removes the other source grouping from this file, squash this line in with that review.
- Joseph Wu
On Aug. 1, 2017, 5:53 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61288/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:53 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7811
> https://issues.apache.org/jira/browse/MESOS-7811
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Linked `libprocess` to `stout` interface library.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 3e621f97b683012beca5705fbf3e4000d686f3ab
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake 75af774e1460319cef1efdf801eb97f34eada0e7
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 5a23990825de04f27bd5f74c82e10b702974f875
> 3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d
>
>
> Diff: https://reviews.apache.org/r/61288/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 61288: Linked `libprocess` to `stout` interface
library.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61288/#review182352
-----------------------------------------------------------
Ship it!
[Tentative "Ship It!" as I review this entire chain.]
I'm going to mention https://reviews.apache.org/r/61286/ in the commit description. (And I might tweak your chain's dependencies a little later, so that they are logically grouped.)
- Joseph Wu
On Aug. 1, 2017, 5:53 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61288/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 5:53 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Linked `libprocess` to `stout` interface library.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 3e621f97b683012beca5705fbf3e4000d686f3ab
> 3rdparty/libprocess/cmake/ProcessConfigure.cmake 75af774e1460319cef1efdf801eb97f34eada0e7
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 5a23990825de04f27bd5f74c82e10b702974f875
> 3rdparty/libprocess/src/CMakeLists.txt fbad7a0dd0347a308ba504ff7daeed187dd1f94d
>
>
> Diff: https://reviews.apache.org/r/61288/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>