You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/21 18:02:17 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #6739: Reduce code / allocations when printing Exprs
alamb opened a new pull request, #6739:
URL: https://github.com/apache/arrow-datafusion/pull/6739
# Which issue does this PR close?
Related to https://github.com/apache/arrow-datafusion/issues/6677
# Rationale for this change
Using a macro to format Vec's of Exprs adds more code and it does a bunch of allocations (both `String` and `Vec`) that we can avoid.
See https://github.com/apache/arrow-datafusion/pull/6708#discussion_r1236829200 for more context
# What changes are included in this PR?
Change macro to functions and `impl Display`
cc @parkma99
# Are these changes tested?
Yes, by existing tests
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6739: Reduce code / allocations when printing Exprs
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6739:
URL: https://github.com/apache/arrow-datafusion/pull/6739#issuecomment-1649734736
I have no plans to pursue this PR at this time, so closing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] parkma99 commented on pull request #6739: Reduce code / allocations when printing Exprs
Posted by "parkma99 (via GitHub)" <gi...@apache.org>.
parkma99 commented on PR #6739:
URL: https://github.com/apache/arrow-datafusion/pull/6739#issuecomment-1602502291
I am a beginner of Rust. I have no thoughts on this.😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #6739: Reduce code / allocations when printing Exprs
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #6739: Reduce code / allocations when printing Exprs
URL: https://github.com/apache/arrow-datafusion/pull/6739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org