[GitHub] [spark] kachayev commented on a change in pull request #28133: [SPARK-31156][SQL] DataFrameStatFunctions API to be consistent with respect to Column type

[GitBox <gi...@apache.org>]

kachayev commented on a change in pull request #28133: [SPARK-31156][SQL] DataFrameStatFunctions API to be consistent with respect to Column type
URL: https://github.com/apache/spark/pull/28133#discussion_r403815859
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameStatFunctions.scala
 ##########
 @@ -69,10 +69,10 @@ final class DataFrameStatFunctions private[sql](df: DataFrame) {
    * @since 2.0.0
    */
   def approxQuantile(
-      col: String,
+      colName: String,
 
 Review comment:
   Oh, my bad. I changed the name to be more explicit about the argument (as it's column name not the column itself). Let me revert the change if you would prefer the old name

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org