You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/15 08:23:15 UTC

[GitHub] [inlong] featzhang opened a new pull request, #7239: [INLONG-7238][Dashboard] Support cascading of redis cluster / data-type and format configuration

featzhang opened a new pull request, #7239:
URL: https://github.com/apache/inlong/pull/7239

   …pe and format configuration
   
   ### Prepare a Pull Request
   
   - [INLONG-7238][Dashboard] Support cascading of redis cluster / data-type and format configuration
   
   - Fixes #7238 
   
   ### Motivation
   
   ![QQ20230115-160449-HD-2](https://user-images.githubusercontent.com/5709212/212530144-511e5d8d-8980-42d3-8263-f628ef862047.gif)
   
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [x] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
     *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7239: [INLONG-7238][Dashboard] Support cascading of redis cluster / data-type and format configuration

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #7239:
URL: https://github.com/apache/inlong/pull/7239


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on a diff in pull request #7239: [INLONG-7238][Dashboard] Support cascading of redis cluster / data-type and format configuration

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on code in PR #7239:
URL: https://github.com/apache/inlong/pull/7239#discussion_r1072494009


##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -311,19 +311,39 @@
   "meta.Sinks.Redis.IsMetaField": "是否为元字段",
   "meta.Sinks.Redis.FieldFormat": "字段格式",
   "meta.Sinks.Redis.FieldDescription": "字段描述",
-  "meta.Sinks.Redis.clusterMode": "集群模式",
-  "meta.Sinks.Redis.database": "DatabaseID",
-  "meta.Sinks.Redis.password": "密码",
-  "meta.Sinks.Redis.ttl": "TTL",
+  "meta.Sinks.Redis.ClusterMode": "集群模式",
+  "meta.Sinks.Redis.Database": "DatabaseID",
+  "meta.Sinks.Redis.Password": "密码",
+  "meta.Sinks.Redis.Ttl": "TTL",
+  "meta.Sinks.Redis.TtlUnit": "秒",
   "meta.Sinks.Redis.ExtList": "高级参数",
   "meta.Sinks.Redis.Timeout": "超时时间",
   "meta.Sinks.Redis.SoTimeout": "读取超时时间",
   "meta.Sinks.Redis.MaxTotal": "最大连接数",
   "meta.Sinks.Redis.MaxIdle": "最大空闲连接数",
   "meta.Sinks.Redis.MinIdle": "最小空闲连接数",
-  "meta.Sinks.Redis.maxRetries": "最大重试次数",
-  "meta.Sinks.Redis.dataType": "数据类型",
-  "meta.Sinks.Redis.schemaMapMode": "Schema映射模式",
+  "meta.Sinks.Redis.MaxRetries": "最大重试次数",
+  "meta.Sinks.Redis.DataType": "数据类型",
+  "meta.Sinks.Redis.SchemaMapMode": "Schema映射模式",
+  "meta.Sinks.Redis.Host": "Host",
+  "meta.Sinks.Redis.Port": "端口",
+  "meta.Sinks.Redis.SentinelMasterName": "主节点名称",
+  "meta.Sinks.Redis.SentinelsInfo": "哨兵信息",
+  "meta.Sinks.Redis.ClusterNodes": "集群节点",
+  "meta.Sinks.Redis.TimeoutUnit": "秒",
+  "meta.Sinks.Redis.SoTimeoutUnit": "秒",
+  "meta.Sinks.Redis.ClusterModeHelper": "请选择Redis集群模式",

Review Comment:
   ```suggestion
     "meta.Sinks.Redis.ClusterModeHelper": "请选择 Redis 集群模式",
   ```



##########
inlong-dashboard/src/locales/cn.json:
##########
@@ -311,19 +311,39 @@
   "meta.Sinks.Redis.IsMetaField": "是否为元字段",
   "meta.Sinks.Redis.FieldFormat": "字段格式",
   "meta.Sinks.Redis.FieldDescription": "字段描述",
-  "meta.Sinks.Redis.clusterMode": "集群模式",
-  "meta.Sinks.Redis.database": "DatabaseID",
-  "meta.Sinks.Redis.password": "密码",
-  "meta.Sinks.Redis.ttl": "TTL",
+  "meta.Sinks.Redis.ClusterMode": "集群模式",
+  "meta.Sinks.Redis.Database": "DatabaseID",
+  "meta.Sinks.Redis.Password": "密码",
+  "meta.Sinks.Redis.Ttl": "TTL",
+  "meta.Sinks.Redis.TtlUnit": "秒",
   "meta.Sinks.Redis.ExtList": "高级参数",
   "meta.Sinks.Redis.Timeout": "超时时间",
   "meta.Sinks.Redis.SoTimeout": "读取超时时间",
   "meta.Sinks.Redis.MaxTotal": "最大连接数",
   "meta.Sinks.Redis.MaxIdle": "最大空闲连接数",
   "meta.Sinks.Redis.MinIdle": "最小空闲连接数",
-  "meta.Sinks.Redis.maxRetries": "最大重试次数",
-  "meta.Sinks.Redis.dataType": "数据类型",
-  "meta.Sinks.Redis.schemaMapMode": "Schema映射模式",
+  "meta.Sinks.Redis.MaxRetries": "最大重试次数",
+  "meta.Sinks.Redis.DataType": "数据类型",
+  "meta.Sinks.Redis.SchemaMapMode": "Schema映射模式",

Review Comment:
   ```suggestion
     "meta.Sinks.Redis.SchemaMapMode": "Schema 映射模式",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org