You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/02/04 13:31:45 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #24003: Extract openGauss special impl from AbstractDataSourcePreparer to OpenGaussDataSourcePreparer
sandynz opened a new pull request, #24003:
URL: https://github.com/apache/shardingsphere/pull/24003
Changes proposed in this pull request:
- Move special prepareTargetSchemas impl to OpenGaussDataSourcePreparer
- Move special executeTargetTableSQL impl to OpenGaussDataSourcePreparer
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24003: Extract openGauss special impl from AbstractDataSourcePreparer to OpenGaussDataSourcePreparer
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24003:
URL: https://github.com/apache/shardingsphere/pull/24003#issuecomment-1416759830
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24003](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0096a8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d3a6266da32688cc8744599d71c76826a91f1599?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d3a6266) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #24003 +/- ##
============================================
+ Coverage 50.06% 50.07% +0.01%
+ Complexity 1563 1562 -1
============================================
Files 3235 3235
Lines 53245 53243 -2
Branches 9797 9796 -1
============================================
+ Hits 26659 26664 +5
+ Misses 24235 24228 -7
Partials 2351 2351
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...prepare/datasource/AbstractDataSourcePreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL3ByZXBhcmUvZGF0YXNvdXJjZS9BYnN0cmFjdERhdGFTb3VyY2VQcmVwYXJlci5qYXZh) | `22.72% <ø> (+0.08%)` | :arrow_up: |
| [...repare/datasource/OpenGaussDataSourcePreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlhbGVjdC9vcGVuZ2F1c3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvb3BlbmdhdXNzL3ByZXBhcmUvZGF0YXNvdXJjZS9PcGVuR2F1c3NEYXRhU291cmNlUHJlcGFyZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/shardingsphere/encrypt/rule/EncryptRule.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZW5jcnlwdC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbmNyeXB0L3J1bGUvRW5jcnlwdFJ1bGUuamF2YQ==) | `78.57% <0.00%> (-1.70%)` | :arrow_down: |
| [...r/query/ShowMigrationCheckAlgorithmsResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9taWdyYXRpb24vZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dNaWdyYXRpb25DaGVja0FsZ29yaXRobXNSZXN1bHRTZXQuamF2YQ==) | | |
| [...uery/ShowMigrationSourceStorageUnitsResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9taWdyYXRpb24vZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dNaWdyYXRpb25Tb3VyY2VTdG9yYWdlVW5pdHNSZXN1bHRTZXQuamF2YQ==) | | |
| [...tsql/ral/queryable/ShowMigrationRuleResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93TWlncmF0aW9uUnVsZVJlc3VsdFNldC5qYXZh) | | |
| [...stsql/ral/queryable/ShowMigrationRuleExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3F1ZXJ5YWJsZS9TaG93TWlncmF0aW9uUnVsZUV4ZWN1dG9yLmphdmE=) | `44.44% <0.00%> (ø)` | |
| [...er/query/ShowMigrationCheckAlgorithmsExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9taWdyYXRpb24vZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dNaWdyYXRpb25DaGVja0FsZ29yaXRobXNFeGVjdXRvci5qYXZh) | `33.33% <0.00%> (ø)` | |
| [...query/ShowMigrationSourceStorageUnitsExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9taWdyYXRpb24vZGlzdHNxbC9oYW5kbGVyL3F1ZXJ5L1Nob3dNaWdyYXRpb25Tb3VyY2VTdG9yYWdlVW5pdHNFeGVjdXRvci5qYXZh) | `33.33% <0.00%> (ø)` | |
| ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/24003?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy merged pull request #24003: Extract openGauss special impl from AbstractDataSourcePreparer to OpenGaussDataSourcePreparer
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy merged PR #24003:
URL: https://github.com/apache/shardingsphere/pull/24003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org