You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "DrFaust92 (via GitHub)" <gi...@apache.org> on 2023/10/06 14:57:02 UTC
[PR] bump open api image to v7.0.1 [airflow]
DrFaust92 opened a new pull request, #34805:
URL: https://github.com/apache/airflow/pull/34805
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.3.0 [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34805: bump open api image to v7.3.0
URL: https://github.com/apache/airflow/pull/34805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.3.0 [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34805:
URL: https://github.com/apache/airflow/pull/34805#issuecomment-2027836367
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1367956354
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
Yeah. I think there are also another reason we should discuss it - namely security/release process for the clients. The "Python API" client we release might be seen as an "official ASF Source package"
Currently we are voting on Python Client and we do not check the provenence of it - because this is code that got genereated by the release manager. and committed - unreviewable and unverifiable.
So IMHO upgrading the client is also an opportunity to update the build and release process - what should happen, we (PMC members) should be able to verify that the build has been generated by the release manager from the API specification and not tampered with. It might be a "reproducible" build or just "verifiable build" - but it boils down to being able to run the build and compare if what comes out of it (providing sufficient external tools we can rely-on - such as official image released by open-api).
I think we can solve both problems at the same time - vy improving automation and adding simple-to-add verification step whether the package we are voting on is "really" generated from the specification without being tampered with.
This is part of the security improvement of our release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
I am afraid @ephraimbuddy is right.
On the other hand this starts to be a little blocking. For instance for the go client, and other client issues where we need to manually fix things. (Missing supports for certain keywords in the spec etc...).
We didn't discuss this but maybe we could do a major release for clients, independantly of airflow major release, just an idea, to not have clients stuck for a long long time. Like update the client versionning policy to allow that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #34805:
URL: https://github.com/apache/airflow/pull/34805#issuecomment-1862248683
@DrFaust92 , can you rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
I am afraid @ephraimbuddy is right.
On the other hand this starts to be a little blocking. For instance for the go client, and other client issues where we need to manually fix things. (Missing supports for certain keywords in the spec etc...).
We didn't discuss this but maybe we could do a major release for clients, independantly of airflow major release, just an idea, to not have clients stuck for a long long time. Like update the client versionning policy to allow that. I don't think major version needs to match between client and airflow core. (It will be a little harder to handle but worth I believe).
If this sounds like a idea worth discussing, I can bring that to the dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1367956354
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
Yeah. I think there are also another reason we should discuss it - namely security/release process for the clients. The "Python API" client we release might be seen as an "official ASF Source package"
Currently we are voting on Python Client and we do not check the provenence of it - because this is code that got genereated by the release manager. and committed - unreviewable and unverifiable.
So IMHO upgrading the client is also an opportunity to update the build and release process - what should happen, we (PMC members) should be able to verify that the build has been generated by the release manager from the API specification and not tampered with. It might be a "reproducible" build or just "verifiable build" - but it boils down to being able to run the build and compare if what comes out of it (providing sufficient external tools we can rely-on - such as official image released by open-api).
I think we can solve both problems at the same time - by improving automation and adding simple-to-add verification step whether the package we are voting on is "really" generated from the specification without being tampered with.
This is part of the security improvement of our release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "DrFaust92 (via GitHub)" <gi...@apache.org>.
DrFaust92 closed pull request #34805: bump open api image to v7.0.1
URL: https://github.com/apache/airflow/pull/34805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.1.0 [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34805:
URL: https://github.com/apache/airflow/pull/34805#issuecomment-1930994976
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1367956354
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
Yeah. I think there are also another reason we should discuss it - namely security/release process for the clients. The "Python API" client we release might be seen as an "official ASF Source package"
Also there is one more point in general to discuss for that one, Currently we are voting on Python Client and we do not check the provenence of it - because this is code that got genereated by the release manager. and committed - unreviewable and unverifiable.
So IMHO upgrading the client is also an opportunity to update the build and release process - what should happen, we (PMC members) should be able to verify that the build has been generated by the release manager from the API specification and not tampered with. It might be a "reproducible" build or just "verifiable build" - but it boils down to being able to run the build and compare if what comes out of it (providing sufficient external tools we can rely-on - such as official image released by open-api).
I think we can solve both problems at the same time - vy improving automation and adding simple-to-add verification step whether the package we are voting on is "really" generated from the specification without being tampered with.
This is part of the security improvement of our release process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1367841259
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
@pierrejeambrun i think mailing list discussion is required here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
I am afraid @ephraimbuddy is right.
On the other hand this starts to be a little blocking. For instance for the go client, and other client issues where we need to manually fix things. (Missing supports for certain keywords in the spec etc...).
We didn't discuss this but maybe we could do a major release for clients, independantly of airflow major release, just an idea, to not have clients stuck for a long long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #34805: bump open api image to v7.0.1
URL: https://github.com/apache/airflow/pull/34805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
I am afraid @ephraimbuddy is right.
On the other hand this starts to be a little blocking. For instance for the go client, and other client issues where we need to manually fix things. (Missing supports for certain keywords in the spec etc...).
We didn't discuss this but maybe we could do a major release for clients, independantly of airflow major release, just an idea, to not have clients stuck for a long long time. Like update the client versionning policy to allow that. I don't think major version needs to match between client and airflow core. (It will be a little harder to handle but worth I believe).
If this sounds like an idea worth discussing, I can bring that to the dev list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
I am afraid @ephraimbuddy is right.
On the other hand this starts to be a little blocking. For instance for the go client, and other client issues where we need to manually fix things. (Missing supports for certain keywords in the spec etc...).
We didn't discuss this but maybe we could do a major release for client, independantly of airflow major release, just an idea, to not have clients stuck for a long long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #34805:
URL: https://github.com/apache/airflow/pull/34805#discussion_r1348872581
##########
clients/gen/common.sh:
##########
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
-OPENAPI_GENERATOR_CLI_VER=5.4.0
+OPENAPI_GENERATOR_CLI_VER=7.0.1
Review Comment:
This will cause a lot of breaking changes to the RESTAPI. We should reserve it for the next major
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bump open api image to v7.0.1 [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34805:
URL: https://github.com/apache/airflow/pull/34805#issuecomment-1843917980
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org