You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Dawid Weiss (Jira)" <ji...@apache.org> on 2021/10/01 07:19:00 UTC
[jira] [Commented] (LUCENE-10139) ExternalRefSorter should return a
covariant with a subtype of BytesRefIterator that is Closeable
[ https://issues.apache.org/jira/browse/LUCENE-10139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423148#comment-17423148 ]
Dawid Weiss commented on LUCENE-10139:
--------------------------------------
The PR is here, don't know why it doesn't show up.
https://github.com/apache/lucene/pull/340
> ExternalRefSorter should return a covariant with a subtype of BytesRefIterator that is Closeable
> -------------------------------------------------------------------------------------------------
>
> Key: LUCENE-10139
> URL: https://issues.apache.org/jira/browse/LUCENE-10139
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
>
> This is a trivial cleanup to make ExternalRefSorter return a covariant subtype of BytesRefIterator that is Closeable. This way callers of iterator() have a way of making sure I/O resources are closed without fully exhausting the iterator (in case of exceptions happening somewhere while scanning the byte refs, for example).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org