You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org> on 2017/11/01 22:41:00 UTC

[jira] [Commented] (RATIS-124) RaftLog should be sync'ed on the entries appended but not the latest entry

    [ https://issues.apache.org/jira/browse/RATIS-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234889#comment-16234889 ] 

Tsz Wo Nicholas Sze commented on RATIS-124:
-------------------------------------------

I suggest to
- change RaftLog.append and appendEntry to return CompletableFuture(s);
- let RaftServerImpl.appendEntries wait for the futures to be completed; and
- remove the logSync().

The future returned can also used to sync writeStateMachineData; see RATIS-122.

> RaftLog should be sync'ed on the entries appended but not the latest entry
> --------------------------------------------------------------------------
>
>                 Key: RATIS-124
>                 URL: https://issues.apache.org/jira/browse/RATIS-124
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Priority: Major
>
> In RaftServerImpl.appendEntries, it first appends entries to RaftLog and then calls logSync().  It sync the latest entry which is not necessarily the last entry appended by this call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)