[GitHub] [carbondata] akashrn5 commented on a change in pull request #4115: [CARBONDATA-4163] Support adding of single-level complex columns(array/struct)

[GitBox <gi...@apache.org>]

akashrn5 commented on a change in pull request #4115:
URL: https://github.com/apache/carbondata/pull/4115#discussion_r609663124



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##########
@@ -275,6 +275,56 @@ class AlterTableColumnSchemaGenerator(
         allColumns ++= Seq(columnSchema)
       }
       newCols ++= Seq(columnSchema)
+      if(field.dataType== Some("Array") ) {
+        columnSchema.setNumberOfChild(field.children.size)
+        val childField = field.children.get(0)
+        val childSchema: ColumnSchema = TableNewProcessor.createColumnSchema(
+          childField,

Review comment:
       @akkio-97 i think here once you added column, the column will be at last, i mean to say like below
   
   existing dim + new added dim + existing measures + new measures, same has to be present in thrift column schema also, you can refer the existing test cases to know better.
   
   Also, have a test cases, with sort column, measures in sort column, dim in sort column etc,
   
   please recheck and correct this and confirm.

##########
File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##########
@@ -585,7 +585,9 @@ public void readColumnChunks(RawBlockletColumnChunks rawBlockletColumnChunks) th
         }
       } else {
         GenericQueryType complexType = complexDimensionInfoMap.get(dimensionChunkIndex[i]);
-        complexType.fillRequiredBlockData(rawBlockletColumnChunks);
+        if (complexType != null) {

Review comment:
       before this PR, why null check was not  there?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org