You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/01 02:37:23 UTC
[GitHub] [iotdb] LebronAl commented on a change in pull request #2662: Fix statistics value in SyncClientPool/AsyncClientPool have concurren…
LebronAl commented on a change in pull request #2662:
URL: https://github.com/apache/iotdb/pull/2662#discussion_r584409119
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/client/async/AsyncClientPool.java
##########
@@ -195,12 +198,12 @@ void recreateClient(Node node) {
clientCaches.computeIfAbsent(clusterNode, n -> new ArrayDeque<>());
try {
AsyncClient asyncClient = asyncClientFactory.getAsyncClient(node, this);
- clientStack.push(asyncClient);
+ clientStack.addLast(asyncClient);
Review comment:
what's the benefit of changing stack to queue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org