You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/15 03:15:25 UTC
[GitHub] [kylin] DoiMasayuki opened a new pull request #1062: Making uniform
position of variable declaration statements
DoiMasayuki opened a new pull request #1062: Making uniform position of variable declaration statements
URL: https://github.com/apache/kylin/pull/1062
This fix is based on similar methods in this repository, as described below.
https://github.com/apache/kylin/blob/f41c6c8198e5cad295e9212c6a0047d83bd54ae2/stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/client/HttpCoordinatorClient.java#L226-L236
https://github.com/apache/kylin/blob/f41c6c8198e5cad295e9212c6a0047d83bd54ae2/stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/client/HttpCoordinatorClient.java#L238-L248
https://github.com/apache/kylin/blob/f41c6c8198e5cad295e9212c6a0047d83bd54ae2/stream-coordinator/src/main/java/org/apache/kylin/stream/coordinator/client/HttpCoordinatorClient.java#L250-L260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1062: Making uniform
position of variable declaration statements
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1062: Making uniform position of variable declaration statements
URL: https://github.com/apache/kylin/pull/1062#issuecomment-574486203
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f41c6c8`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1062 +/- ##
=========================================
Coverage ? 25.06%
Complexity ? 6220
=========================================
Files ? 1438
Lines ? 87673
Branches ? 12256
=========================================
Hits ? 21979
Misses ? 63545
Partials ? 2149
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ream/coordinator/client/HttpCoordinatorClient.java](https://codecov.io/gh/apache/kylin/pull/1062/diff?src=pr&el=tree#diff-c3RyZWFtLWNvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vY29vcmRpbmF0b3IvY2xpZW50L0h0dHBDb29yZGluYXRvckNsaWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=footer). Last update [f41c6c8...f39a16d](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1062: Making uniform position
of variable declaration statements
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1062: Making uniform position of variable declaration statements
URL: https://github.com/apache/kylin/pull/1062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io edited a comment on issue #1062: Making uniform
position of variable declaration statements
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1062: Making uniform position of variable declaration statements
URL: https://github.com/apache/kylin/pull/1062#issuecomment-574486203
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=h1) Report
> Merging [#1062](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/f41c6c8198e5cad295e9212c6a0047d83bd54ae2?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1062 +/- ##
=========================================
Coverage 25.05% 25.05%
Complexity 6220 6220
=========================================
Files 1438 1438
Lines 87673 87673
Branches 12256 12256
=========================================
Hits 21966 21966
Misses 63553 63553
Partials 2154 2154
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=footer). Last update [f41c6c8...f39a16d](https://codecov.io/gh/apache/kylin/pull/1062?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services