You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/16 00:40:15 UTC
Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
Bugs: MESOS-9639
https://issues.apache.org/jira/browse/MESOS-9639
Repository: mesos
Description
-------
Since the fine-grained version-specific per-CSI-call metrics are not
very useful for operators, and most informations are highly correlated
to per-operation metrics, these metrics are aggregated and made CSI
version agnostic.
Diffs
-----
docs/monitoring.md 2c2320ad01a5f46a5253c880d34a1c9ac6cf4ca4
src/csi/metrics.hpp PRE-CREATION
src/csi/metrics.cpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70225/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review213762
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70168, 70169, 70213, 70214, 70215, 70216, 70217, 70222, 70223, 70225]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 16, 2019, 12:40 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 12:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 2c2320ad01a5f46a5253c880d34a1c9ac6cf4ca4
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70225/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review213760
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70168', '70169', '70213', '70214', '70215', '70216', '70217', '70222', '70223', '70225']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2972/mesos-review-70225
Relevant logs:
- [mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2972/mesos-review-70225/logs/mesos-tests-cmake.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500): warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501): warning C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (20) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\csi\v0_volume_manager.cpp(258): error C2397: conversion from 'google::protobuf::int64' to 'Bytes' requires a narrowing conversion [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
1 Error(s)
Time Elapsed 00:09:03.27
```
- Mesos Reviewbot Windows
On March 15, 2019, 5:40 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 15, 2019, 5:40 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 2c2320ad01a5f46a5253c880d34a1c9ac6cf4ca4
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70225/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review214087
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70313', '70314', '70315', '70316', '70245', '70168', '70247', '70248', '70213', '70214', '70216', '70215', '70217', '70284', '70222', '70285', '70223', '70225']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3026/mesos-review-70225
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3026/mesos-review-70225/logs/mesos-tests.log):
```
I0327 08:05:28.029320 24212 master.cpp:1295] Agent 44693939-c920-413b-a64c-fe502a9a79de-S0 at slave(500)@192.10.1.7:58261 (windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0327 08:05:28.029320 24212 master.cpp:3330] Disconnecting agent 44693939-c920-413b-a64c-fe502a9a79de-S0 at slave(500)@192.10.1.7:58261 (windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0327 08:05:28.029320 24212 master.cpp:3349] Deactivating agent 44693939-c920-413b-a64c-fe502a9a79de-S0 at slave(500)@192.10.1.7:58261 (windows-03.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0327 08:05:28.031342 24212 containerizer.cpp:2576] Destroying container 74a8f195-10ca-41a0-bb89-f6d6c3e3e4f4 in RUNNING state
I0327 08:05:28.031342 24212 containerizer.cpp:3278] Transitioning the state of container 74a8f195-10ca-41a0-bb89-f6d6c3e3e4f4 from RUNNING to DESTROYING
I0327 08:05:28.031342 23996 hierarchical.cpp:391] Removed framework 44693939-c920-413b-a64[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (681 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (698 ms total)
[----------] Global test environment tear-down
[==========] 1132 tests from 108 test cases ran. (555018 ms total)
[ PASSED ] 1130 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName
2 FAILED TESTS
YOU HAVE 231 DISABLED TESTS
c-fe502a9a79de-0000
I0327 08:05:28.031342 24212 launcher.cpp:161] Asked to destroy container 74a8f195-10ca-41a0-bb89-f6d6c3e3e4f4
I0327 08:05:28.031342 23996 hierarchical.cpp:828] Agent 44693939-c920-413b-a64c-fe502a9a79de-S0 deactivated
W0327 08:05:28.032325 23176 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=10840 to peer '192.10.1.7:60667': IO failed with error code: The specified network name is no longer available.
W0327 08:05:28.033329 23176 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=11144 to peer '192.10.1.7:60666': IO failed with error code: The specified network name is no longer available.
I0327 08:05:28.089020 23352 containerizer.cpp:3117] Container 74a8f195-10ca-41a0-bb89-f6d6c3e3e4f4 has exited
I0327 08:05:28.117024 20072 master.cpp:1135] Master terminating
I0327 08:05:28.119022 20340 hierarchical.cpp:679] Removed agent 44693939-c920-413b-a64c-fe502a9a79de-S0
I0327 08:05:28.478070 23176 process.cpp:927] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On March 16, 2019, 12:40 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 12:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70225/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/
-----------------------------------------------------------
(Updated April 2, 2019, 5:54 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased and took Benjamin's suggestion.
Bugs: MESOS-9639
https://issues.apache.org/jira/browse/MESOS-9639
Repository: mesos
Description
-------
Since the fine-grained version-specific per-CSI-call metrics are not
very useful for operators, and most informations are highly correlated
to per-operation metrics, these metrics are aggregated and made CSI
version agnostic.
Diffs (updated)
-----
docs/monitoring.md 239077b354d1af73d5b0a358e19d67574b2093a6
src/csi/metrics.hpp PRE-CREATION
src/csi/metrics.cpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/tests/storage_local_resource_provider_tests.cpp 0fbd602a196c6994c587e2918675ac6a5446aa1e
Diff: https://reviews.apache.org/r/70225/diff/7/
Changes: https://reviews.apache.org/r/70225/diff/6-7/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On March 28, 2019, 9:23 a.m., Benjamin Bannier wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Line 4139 (original), 4139 (patched)
> > <https://reviews.apache.org/r/70225/diff/6/?file=2135923#file2135923line4139>
> >
> > Do you think it would make sense to put the value from intitial setup into a constant and then simply reference it? Something like
> > ```
> > const size_t finished = 9;
> >
> > // ...
> >
> > EXPECT_EQ(finished + 2, snapshot.values.at(metricName("csi_plugin/rpcs_finished"));
> > ```
Sounds a great idea!
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review214165
-----------------------------------------------------------
On March 28, 2019, 8 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 8 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70225/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review214165
-----------------------------------------------------------
Ship it!
src/tests/storage_local_resource_provider_tests.cpp
Line 4139 (original), 4139 (patched)
<https://reviews.apache.org/r/70225/#comment300351>
Do you think it would make sense to put the value from intitial setup into a constant and then simply reference it? Something like
```
const size_t finished = 9;
// ...
EXPECT_EQ(finished + 2, snapshot.values.at(metricName("csi_plugin/rpcs_finished"));
```
src/tests/storage_local_resource_provider_tests.cpp
Line 5207 (original), 5107 (patched)
<https://reviews.apache.org/r/70225/#comment300353>
Same for this test?
- Benjamin Bannier
On March 28, 2019, 9 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 28, 2019, 9 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70225/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/
-----------------------------------------------------------
(Updated March 28, 2019, 8 a.m.)
Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-9639
https://issues.apache.org/jira/browse/MESOS-9639
Repository: mesos
Description
-------
Since the fine-grained version-specific per-CSI-call metrics are not
very useful for operators, and most informations are highly correlated
to per-operation metrics, these metrics are aggregated and made CSI
version agnostic.
Diffs (updated)
-----
docs/monitoring.md 54b872f579dbc68ca5f67f4cc1ba34065a09aee2
src/csi/metrics.hpp PRE-CREATION
src/csi/metrics.cpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
Diff: https://reviews.apache.org/r/70225/diff/6/
Changes: https://reviews.apache.org/r/70225/diff/5-6/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review213769
-----------------------------------------------------------
PASS: Mesos patch 70225 was successfully built and tested.
Reviews applied: `['70168', '70169', '70213', '70214', '70215', '70216', '70217', '70222', '70223', '70225']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2973/mesos-review-70225
- Mesos Reviewbot Windows
On March 16, 2019, 12:40 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 12:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 2c2320ad01a5f46a5253c880d34a1c9ac6cf4ca4
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70225/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70225: Made CSI plugin RPC metrics agnostic to CSI
versions.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70225/#review213770
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70168, 70169, 70213, 70214, 70215, 70216, 70217, 70222, 70223, 70225]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 16, 2019, 8:40 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70225/
> -----------------------------------------------------------
>
> (Updated March 16, 2019, 8:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-9639
> https://issues.apache.org/jira/browse/MESOS-9639
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the fine-grained version-specific per-CSI-call metrics are not
> very useful for operators, and most informations are highly correlated
> to per-operation metrics, these metrics are aggregated and made CSI
> version agnostic.
>
>
> Diffs
> -----
>
> docs/monitoring.md 2c2320ad01a5f46a5253c880d34a1c9ac6cf4ca4
> src/csi/metrics.hpp PRE-CREATION
> src/csi/metrics.cpp PRE-CREATION
> src/csi/service_manager.cpp PRE-CREATION
> src/csi/v0_volume_manager.cpp PRE-CREATION
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70225/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>