[jira] Updated: (DERBY-3586) Remove am.Connection.reset(LogWriter,ClientBaseDataSource,boolean) and called methods

["Kristian Waagan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3586:
-----------------------------------

    Attachment: derby-3586-1a-connection_reset3_removal.diff

'derby-3586-1a-connection_reset3_removal.diff' removes the unused code.
The code compiles after the patch is applied, and I don't think reflection is used in the client. Running regression tests anyway.
Expect to commit this tomorrow.

I'm a bit unsure about whether to port this to 10.3, I'm leaning towards not doing it.

> Remove am.Connection.reset(LogWriter,ClientBaseDataSource,boolean) and called methods
> -------------------------------------------------------------------------------------
>
>                 Key: DERBY-3586
>                 URL: https://issues.apache.org/jira/browse/DERBY-3586
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.2.2.0, 10.3.2.1, 10.4.0.0, 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Trivial
>             Fix For: 10.4.1.0, 10.5.0.0
>
>         Attachments: derby-3586-1a-connection_reset3_removal.diff
>
>
> am.Connection.reset(LogWriter,ClientBaseDataSource,boolean) isn't called and can be removed.
> Further, the following methods are only called from the reset(3):
>  * abstract Connection.reset_(3) and impl NetConnection.reset_(3)
>  * NetConnection.resetNetConnection(3)
> All these methods have cousins taking 4 arguments, which are being used by on one occasion: ClientPooledConnection.getConnection().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.