You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/27 17:19:57 UTC
[GitHub] [pulsar] poorbarcode opened a new pull request, #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
poorbarcode opened a new pull request, #16826:
URL: https://github.com/apache/pulsar/pull/16826
### Motivation
see #15051
There have conflicts when cherry-picking #15051 PR (branch 2.8 has no `mock static` support), so I created a separate PR to fix branch-2.8
### Modifications
Swap the execution order of duplicate validation and maximum validation
### Documentation
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc`
- [ ] `doc-complete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16826:
URL: https://github.com/apache/pulsar/pull/16826#issuecomment-1197591092
We can merge this PR once only CI - Unit / unit-tests (pull_request) failed because there is a broken test, see https://github.com/apache/pulsar/issues/16813.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #16826:
URL: https://github.com/apache/pulsar/pull/16826#issuecomment-1197750884
Merge this PR first, it looks like `NamespacesTest.testDeleteNamespaceWithBundles` is also very flaky.
```
Wanted but not invoked:
asyncResponse.resume(<Capturing argument>);
-> at org.apache.pulsar.broker.admin.NamespacesTest.testDeleteNamespaceWithBundles(NamespacesTest.java:859)
However, there was exactly 1 interaction with this mock:
asyncResponse.resume(
org.apache.pulsar.broker.web.RestException: Failed to find ownership for ServiceUnit:my-tenant/use/test-delete-namespace-with-bundles/0x00000000_0x80000000
);
-> at org.apache.pulsar.broker.web.PulsarWebResource.resumeAsyncResponseExceptionally(PulsarWebResource.java:1226)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged PR #16826:
URL: https://github.com/apache/pulsar/pull/16826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16826:
URL: https://github.com/apache/pulsar/pull/16826#issuecomment-1197070849
@BewareMyPower Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16826:
URL: https://github.com/apache/pulsar/pull/16826#issuecomment-1197672943
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16826:
URL: https://github.com/apache/pulsar/pull/16826#issuecomment-1197589051
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16826: [fix][broker][branch-2.8] Fix potential to add duplicated consumer
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16826:
URL: https://github.com/apache/pulsar/pull/16826#issuecomment-1197485630
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org