You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by shixuan-fan <gi...@git.apache.org> on 2016/06/28 18:11:58 UTC
[GitHub] incubator-quickstep pull request #46: Minor Change: Added move semantic in R...
GitHub user shixuan-fan opened a pull request:
https://github.com/apache/incubator-quickstep/pull/46
Minor Change: Added move semantic in Resolver::WindowPlan
Added move semantic in the constructor of `Resolver::WindowPlan`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep move-semantic-in-window-plan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit dd17322892efac5f2da9af347b8f9ad2f0bbbabb
Author: shixuan-fan <sh...@apache.org>
Date: 2016-06-28T15:42:09Z
Added move semantic in the constructor of window plan
commit 3b07606556fb32ff4715214d97a79f45f296ab5b
Author: shixuan-fan <sh...@apache.org>
Date: 2016-06-28T17:43:24Z
Added NOLINT
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #46: Minor Change: Added move semantic in R...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/46#discussion_r68813836
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -228,9 +228,9 @@ struct Resolver::QueryAggregationInfo {
};
struct Resolver::WindowPlan {
- WindowPlan(const E::WindowInfo &window_info_in,
+ WindowPlan(E::WindowInfo &&window_info_in, // NOLINT(whitespace/operators)
const L::LogicalPtr &logical_plan_in)
--- End diff --
This is optional, but I prefer to reorder the arguments:
```
WindowPlan(const L::LogicalPtr &logical_plan_in,
E::WindowInfo &&window_info_in); // NOLINT(whitespace/operators)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #46: Minor Change: Added move semantic in R...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #46: Minor Change: Added move semantic in R...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/46#discussion_r68813619
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1032,7 +1032,7 @@ L::LogicalPtr Resolver::resolveSelect(
L::LogicalPtr sorted_logical_plan = resolveSortInWindow(logical_plan,
resolved_window);
- WindowPlan window_plan(resolved_window, sorted_logical_plan);
+ WindowPlan window_plan(std::move(resolved_window), sorted_logical_plan);
sorted_window_map.emplace(window.name()->value(), window_plan);
--- End diff --
Please use `move` in `sorted_window_map` as well:
`sorted_window_map.emplace(window.name()->value(), std::move(window_plan));`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---