You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2010/10/27 07:56:19 UTC
[jira] Created: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Replace the value of "bsp.peers.num" in enterBarrier() method
-------------------------------------------------------------
Key: HAMA-321
URL: https://issues.apache.org/jira/browse/HAMA-321
Project: Hama
Issue Type: Bug
Components: bsp
Affects Versions: 0.2.0
Reporter: Edward J. Yoon
Priority: Critical
Fix For: 0.2.0
Each groomserver handles one instance of BSPPeer.
Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (HAMA-321) Replace the value of "bsp.peers.num"
in enterBarrier() method
Posted by "Edward J. Yoon" <ed...@apache.org>.
Could anyone please review this patch?
On Tue, Nov 9, 2010 at 6:39 PM, Hudson (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930029#action_12930029 ]
>
> Hudson commented on HAMA-321:
> -----------------------------
>
> +1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12459148/HAMA-321_v03.patch
> against trunk revision 1032884.
>
> @author +1. The patch does not contain any @author tags.
>
> tests included +1. The patch appears to include 3 new or modified tests.
>
> javadoc +1. The javadoc tool did not generate any warning messages.
>
> javac +1. The applied patch does not generate any new javac compiler warnings.
>
> release audit +1. The applied patch does not generate any new release audit warnings.
>
> findbugs +1. The patch does not introduce any new Findbugs warnings.
>
> core tests +1. The patch passed core unit tests.
>
> Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/testReport/
> Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/findbugsResult/
> Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/artifact/trunk/build/test/checkstyle-errors.html
> Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/console
>
> This message is automatically generated.
>
>> Replace the value of "bsp.peers.num" in enterBarrier() method
>> -------------------------------------------------------------
>>
>> Key: HAMA-321
>> URL: https://issues.apache.org/jira/browse/HAMA-321
>> Project: Hama
>> Issue Type: Bug
>> Components: bsp
>> Affects Versions: 0.2.0
>> Reporter: Edward J. Yoon
>> Assignee: Edward J. Yoon
>> Priority: Critical
>> Fix For: 0.2.0
>>
>> Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>>
>>
>> Each groomserver handles one instance of BSPPeer.
>> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Best Regards, Edward J. Yoon
edwardyoon@apache.org
http://blog.udanax.org
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Attachment: HAMA-321_v03.patch
Since BSP constructor creates instance of jobClient automatically, TestBSPPeer failed.
Attach fixed patch.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Attachment: HAMA-321.patch
This patch allows user to set the number of tasks. Since hama-0.2.0 doesn't support multiple tasks, the JobClient forcely reset the number of tasks as number of GroomServer if the number of tasks is greater than the number of GroomServer.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Status: Patch Available (was: Open)
running patch through hudson.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-321) Replace the value of "bsp.peers.num"
in enterBarrier() method
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929996#action_12929996 ]
Hudson commented on HAMA-321:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459142/HAMA-321.patch
against trunk revision 1032869.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/288/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/288/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/288/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/288/console
This message is automatically generated.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-321) Replace the value of "bsp.peers.num"
in enterBarrier() method
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930020#action_12930020 ]
Hudson commented on HAMA-321:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459145/HAMA-321_v02.patch
against trunk revision 1032884.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/289/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/289/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/289/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/289/console
This message is automatically generated.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-321) Replace the value of "bsp.peers.num"
in enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925265#action_12925265 ]
Edward J. Yoon commented on HAMA-321:
-------------------------------------
And, should we remove the "bsp.peers.num" property from the hama-default.xml?
It is a useless property at the moment.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-321:
-----------------------------------
Assignee: Edward J. Yoon
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Status: Patch Available (was: Open)
Rescheduling.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Status: Open (was: Patch Available)
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Attachment: HAMA-321_v02.patch
added setJobConf() method to BSPPeer.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-321) Replace the value of "bsp.peers.num"
in enterBarrier() method
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930029#action_12930029 ]
Hudson commented on HAMA-321:
-----------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459148/HAMA-321_v03.patch
against trunk revision 1032884.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/290/console
This message is automatically generated.
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch, HAMA-321_v03.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Status: Patch Available (was: Open)
resubmit
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-321) Replace the value of "bsp.peers.num" in
enterBarrier() method
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-321:
--------------------------------
Status: Open (was: Patch Available)
> Replace the value of "bsp.peers.num" in enterBarrier() method
> -------------------------------------------------------------
>
> Key: HAMA-321
> URL: https://issues.apache.org/jira/browse/HAMA-321
> Project: Hama
> Issue Type: Bug
> Components: bsp
> Affects Versions: 0.2.0
> Reporter: Edward J. Yoon
> Assignee: Edward J. Yoon
> Priority: Critical
> Fix For: 0.2.0
>
> Attachments: HAMA-321.patch, HAMA-321_v02.patch
>
>
> Each groomserver handles one instance of BSPPeer.
> Instead of the value of "bsp.peers.num", we should use the number of groomserver.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.