You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/05/13 07:18:04 UTC
Review Request 21198: Added Fix for CLOUDSTACK-6648
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21198/
-----------------------------------------------------------
Review request for cloudstack and Koushik Das.
Bugs: CLOUDSTACK-6648
https://issues.apache.org/jira/browse/CLOUDSTACK-6648
Repository: cloudstack-git
Description
-------
zone creation and test data passing were not proper earlier, and so vm_ha cases were failing. Fixed them now.
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
Diff: https://reviews.apache.org/r/21198/diff/
Testing
-------
Test VM HA ... === TestName: test_vm_ha | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 206.230s
OK
~
~
~
~
Thanks,
Santhosh Edukulla
Re: Review Request 21198: Added Fix for CLOUDSTACK-6648
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21198/#review42814
-----------------------------------------------------------
Ship it!
Added to 4.4-forward. Patch is not getting applied in master, please create a new patch
- Koushik Das
On May 13, 2014, 5:19 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21198/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 5:19 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-6648
> https://issues.apache.org/jira/browse/CLOUDSTACK-6648
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> zone creation and test data passing were not proper earlier, and so vm_ha cases were failing. Fixed them now.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_vm_ha.py f549243
> tools/marvin/marvin/config/test_data.py fbf5e25
>
> Diff: https://reviews.apache.org/r/21198/diff/
>
>
> Testing
> -------
>
> Test VM HA ... === TestName: test_vm_ha | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 206.230s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21198: Added Fix for CLOUDSTACK-6648
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21198/#review42810
-----------------------------------------------------------
Commit 900415b1d847ab4f2ccca75452adc1db009bb261 in cloudstack's branch refs/heads/4.4-forward from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=900415b ]
Fixed CLOUDSTACK-6648
vm_ha cases were failing because of improper zone
and test data passed. Fixed them now.
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Koushik Das <ko...@apache.org>
- ASF Subversion and Git Services
On May 13, 2014, 5:19 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21198/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 5:19 a.m.)
>
>
> Review request for cloudstack and Koushik Das.
>
>
> Bugs: CLOUDSTACK-6648
> https://issues.apache.org/jira/browse/CLOUDSTACK-6648
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> zone creation and test data passing were not proper earlier, and so vm_ha cases were failing. Fixed them now.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_vm_ha.py f549243
> tools/marvin/marvin/config/test_data.py fbf5e25
>
> Diff: https://reviews.apache.org/r/21198/diff/
>
>
> Testing
> -------
>
> Test VM HA ... === TestName: test_vm_ha | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 206.230s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21198: Added Fix for CLOUDSTACK-6648
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21198/
-----------------------------------------------------------
(Updated May 13, 2014, 5:19 a.m.)
Review request for cloudstack and Koushik Das.
Changes
-------
Uploading correct patch.
Bugs: CLOUDSTACK-6648
https://issues.apache.org/jira/browse/CLOUDSTACK-6648
Repository: cloudstack-git
Description
-------
zone creation and test data passing were not proper earlier, and so vm_ha cases were failing. Fixed them now.
Diffs (updated)
-----
test/integration/smoke/test_vm_ha.py f549243
tools/marvin/marvin/config/test_data.py fbf5e25
Diff: https://reviews.apache.org/r/21198/diff/
Testing
-------
Test VM HA ... === TestName: test_vm_ha | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 206.230s
OK
~
~
~
~
Thanks,
Santhosh Edukulla