You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by pi...@apache.org on 2021/12/09 17:17:17 UTC

[submarine] branch master updated: SUBMARINE-1120. Fix Submarine Helm can not start submarine-operator pod error.

This is an automated email from the ASF dual-hosted git repository.

pingsutw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 26ac046  SUBMARINE-1120. Fix Submarine Helm can not start submarine-operator pod error.
26ac046 is described below

commit 26ac0465a662653910405f60e27279dc30784c75
Author: cdmikechen <cd...@hotmail.com>
AuthorDate: Thu Dec 9 15:19:21 2021 +0800

    SUBMARINE-1120. Fix Submarine Helm can not start submarine-operator pod error.
    
    ### What is this PR for?
    Fix https://issues.apache.org/jira/browse/SUBMARINE-1120
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    
    * [x] - Change `submarine-operator` ServiceAccount namespace in helm template so that submarine-operator can start normally.
    
    ### What is the Jira issue?
    
    https://issues.apache.org/jira/browse/SUBMARINE-1120
    
    ### How should this be tested?
    
    Use the `helm install` command to test. And we can directly see the result: whether the `submarine-operator` pod starts and runs normally.
    
    ### Screenshots (if appropriate)
    no
    
    ### Questions:
    * Do the license files need updating? No
    * Are there breaking changes for older versions? No
    * Does this need new documentation? No
    
    Author: cdmikechen <cd...@hotmail.com>
    
    Signed-off-by: Kevin <pi...@apache.org>
    
    Closes #824 from cdmikechen/SUBMARINE-1120 and squashes the following commits:
    
    f322c87a [cdmikechen] SUBMARINE-1120. Fix Submarine Helm can not start submarine-operator pod error.
---
 helm-charts/submarine/templates/rbac.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/helm-charts/submarine/templates/rbac.yaml b/helm-charts/submarine/templates/rbac.yaml
index df95280..e7101b0 100644
--- a/helm-charts/submarine/templates/rbac.yaml
+++ b/helm-charts/submarine/templates/rbac.yaml
@@ -92,7 +92,7 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: submarine-operator
-  namespace: default
+  namespace: {{ .Release.Namespace }}
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
@@ -105,4 +105,4 @@ roleRef:
 subjects:
   - kind: ServiceAccount
     name: submarine-operator
-    namespace: default
+    namespace: {{ .Release.Namespace }}

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org