You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ro...@apache.org on 2022/09/21 10:00:10 UTC
[incubator-uniffle] branch master updated: Adjust the memory required times to match grpc max deadline conf (#218)
This is an automated email from the ASF dual-hosted git repository.
roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new f63cebbf Adjust the memory required times to match grpc max deadline conf (#218)
f63cebbf is described below
commit f63cebbfa631ac17ba28bca24a86556d171c1842
Author: Junfan Zhang <ju...@outlook.com>
AuthorDate: Wed Sep 21 18:00:05 2022 +0800
Adjust the memory required times to match grpc max deadline conf (#218)
### What changes were proposed in this pull request?
Adjust the memory required times from 100 to 50 to match the grpc max deadline conf (60s).
### Why are the changes needed?
If the required memory retry time > 60s, the client will cancel the request. That means the required memory exception wont throw to client side. And the server side wont show any related log.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No need.
---
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java b/server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java
index ce834ce5..7336f6d5 100644
--- a/server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java
+++ b/server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java
@@ -107,7 +107,7 @@ public class ShuffleServerConf extends RssBaseConf {
public static final ConfigOption<Integer> SERVER_MEMORY_REQUEST_RETRY_MAX = ConfigOptions
.key("rss.server.memory.request.retry.max")
.intType()
- .defaultValue(100)
+ .defaultValue(50)
.withDescription("Max times to retry for memory request");
public static final ConfigOption<Long> SERVER_PRE_ALLOCATION_EXPIRED = ConfigOptions