You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "cgivre (via GitHub)" <gi...@apache.org> on 2023/03/30 13:31:57 UTC
[PR] DRILL-8417: Allow Excel Reader to Ignore Formula Errors (drill)
cgivre opened a new pull request, #2783:
URL: https://github.com/apache/drill/pull/2783
# [DRILL-8417](https://issues.apache.org/jira/browse/DRILL-8417): Allow Excel Reader to Ignore Formula Errors
## Description
If Drill encounters an Excel formula which is invalid somehow, such as a `DIV/0`, Drill is unable to proceed and throws a number format exception.
This PR adds a config parameter called `ignoreErrors` which allows Drill to skip such records and returns `null` for that cell. Drill will also output a log warning. When set to `false`, original behavior is retained.
## Documentation
Updated README
* `ignoreErrors`: Defaults to `true`. When set to `true` Drill will return `null` for any
formulas or any values that are unparseable.
## Testing
Added two unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8417: Allow Excel Reader to Ignore Formula Errors (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton commented on PR #2783:
URL: https://github.com/apache/drill/pull/2783#issuecomment-1508106845
Reviewer's note: all format-excel tests do pass, the CI test failures here are a result of as yet unfixed breakage brought in by Calcite 1.35-SNAPSHOT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8417: Allow Excel Reader to Ignore Formula Errors (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2783:
URL: https://github.com/apache/drill/pull/2783#issuecomment-1507822172
>
@jnturton
I updated the PR to default to `false` and updated the README as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8417: Allow Excel Reader to Ignore Formula Errors (drill)
Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2783:
URL: https://github.com/apache/drill/pull/2783#issuecomment-1511468213
Once https://github.com/apache/drill/pull/2794 is merged, I'll rebase and merge this, pending @jnturton's approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DRILL-8417: Allow Excel Reader to Ignore Formula Errors (drill)
Posted by "jnturton (via GitHub)" <gi...@apache.org>.
jnturton merged PR #2783:
URL: https://github.com/apache/drill/pull/2783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org