You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by prokod <gi...@git.apache.org> on 2017/05/06 15:50:01 UTC

[GitHub] spark pull request #17883: [SPARK-20622][SQL]value only based directories pa...

GitHub user prokod opened a pull request:

    https://github.com/apache/spark/pull/17883

    [SPARK-20622][SQL]value only based directories parquet partition discovery

    ## What changes were proposed in this pull request?
    
    A proposal for a solution which will allow Spark SQL to discover parquet partitions for 'value only' named directories.
    
    ## How was this patch tested?
    
    Based on existing test suite with added test cases
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prokod/spark feature/SPARK-20622/SQL/value_only_based_parquet_partition_discovery

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17883.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17883
    
----
commit 8d1d5c82c6f4f9c4a58e11191f20cf508be01f72
Author: Noam Asor <no...@gmail.com>
Date:   2017-05-06T15:02:22Z

    To allow Spark SQL to do parquet partition discovery for 'value only' named dirs
    
    Initial solution and tests
    
    #SPARK-20622

commit 2219021c4597bd3e4b2fa0f35dea1808dab98fbe
Author: Noam Asor <no...@gmail.com>
Date:   2017-05-06T15:42:55Z

    To undup test code
    
    #SPARK-20622

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17883: [SPARK-20622][SQL] parquet partition discovery for 'valu...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/17883
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17883: [SPARK-20622][SQL] parquet partition discovery for 'valu...

Posted by prokod <gi...@git.apache.org>.
Github user prokod commented on the issue:

    https://github.com/apache/spark/pull/17883
  
    Per @xiao321 request I am closing this PR


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #17883: [SPARK-20622][SQL] parquet partition discovery fo...

Posted by prokod <gi...@git.apache.org>.
Github user prokod closed the pull request at:

    https://github.com/apache/spark/pull/17883


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #17883: [SPARK-20622][SQL] parquet partition discovery for 'valu...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/17883
  
    We might not want such a feature in the current stage of Spark SQL. When we decide to continue it, maybe we can revisit it? Could you close this PR? Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org