You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "agchang (via GitHub)" <gi...@apache.org> on 2023/04/05 00:06:40 UTC

[GitHub] [arrow] agchang commented on pull request #34808: GH-34807: [Go] Handle `io.EOF` when reading parquet footer size and magic bytes

agchang commented on PR #34808:
URL: https://github.com/apache/arrow/pull/34808#issuecomment-1496749172

   > Is there more you intend to do here? I'd say that a unit test which uses an implementation that returns the io.EOF and confirms this fixes it would be good. Otherwise this seems fine to me if you think it's ready for review.
   
   I added a test. I wasn't sure of the best way to get a buffer to an underlying valid parquet file for testing purposes, so I pieced together things from other tests -- let me know if there's a better way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org