You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2015/11/10 00:34:56 UTC
Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-13798
https://issues.apache.org/jira/browse/AMBARI-13798
Repository: ambari
Description
-------
The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path. Change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was.
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java e4d44a7
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
Diff: https://reviews.apache.org/r/40110/diff/
Testing
-------
mvn clean test on ambari-metrics.
Manual testing done.
Added unit test to cover this case.
Thanks,
Aravindan Vijayan
Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/#review106504
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java (line 183)
<https://reviews.apache.org/r/40110/#comment165212>
Unnecessary casting.
- Aravindan Vijayan
On Nov. 13, 2015, 9:28 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40110/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 9:28 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-13798
> https://issues.apache.org/jira/browse/AMBARI-13798
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path.
>
> Also change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was. This log statements must be available on ambari-server.log as well.
>
> To make sure that ambari-server prints out the error, I had needed to change the way we read from the StreamProvider and read the error stream from the HttpUrlConnection. Specifically, the StreamProvider interface was changed to URLStreamProvider in all Metrics Property provider classes and tests.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java 640604d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 2ef0a8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8b15569
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java ad35444
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java fb74fab
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java 54857cc
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java 9b23686
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaComponentPropertyProvider.java e531dff
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostComponentPropertyProvider.java 5508cbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java 41a500f
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java d2dbb11
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java cc0219c
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java 0e71049
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java 85e016f
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 2af7452
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 8b60c50
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java ca20e54
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java 9100afd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java beffa9e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 415b97b
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java a7b7553
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestHttpUrlConnection.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java 770dfb6
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java ce865cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java 99a2102
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java a03dfc7
>
> Diff: https://reviews.apache.org/r/40110/diff/
>
>
> Testing
> -------
>
> mvn clean test on ambari-metrics.
>
> Manual testing done.
>
> Added unit test to cover this case.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>
Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/#review106523
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Nov. 13, 2015, 10:42 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40110/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 10:42 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-13798
> https://issues.apache.org/jira/browse/AMBARI-13798
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path.
>
> Also change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was. This log statements must be available on ambari-server.log as well.
>
> To make sure that ambari-server prints out the error, I had needed to change the way we read from the StreamProvider and read the error stream from the HttpUrlConnection. Specifically, the StreamProvider interface was changed to URLStreamProvider in all Metrics Property provider classes and tests.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 2ef0a8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8b15569
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java ad35444
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java fb74fab
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java 54857cc
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java 9b23686
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaComponentPropertyProvider.java e531dff
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostComponentPropertyProvider.java 5508cbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java 41a500f
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java d2dbb11
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java cc0219c
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java 0e71049
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java 85e016f
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 2af7452
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 8b60c50
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java ca20e54
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java beffa9e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 415b97b
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java a7b7553
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestHttpUrlConnection.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java 770dfb6
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java ce865cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java 99a2102
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java a03dfc7
>
> Diff: https://reviews.apache.org/r/40110/diff/
>
>
> Testing
> -------
>
> mvn clean test on ambari-metrics.
>
> Manual testing done.
>
> Added unit test to cover this case.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>
Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 10:42 p.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-13798
https://issues.apache.org/jira/browse/AMBARI-13798
Repository: ambari
Description
-------
The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path.
Also change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was. This log statements must be available on ambari-server.log as well.
To make sure that ambari-server prints out the error, I had needed to change the way we read from the StreamProvider and read the error stream from the HttpUrlConnection. Specifically, the StreamProvider interface was changed to URLStreamProvider in all Metrics Property provider classes and tests.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 2ef0a8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8b15569
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java ad35444
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java fb74fab
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java 54857cc
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java 9b23686
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaComponentPropertyProvider.java e531dff
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostComponentPropertyProvider.java 5508cbe
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java 41a500f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java d2dbb11
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java cc0219c
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java 0e71049
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java 85e016f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 2af7452
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 8b60c50
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java ca20e54
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java beffa9e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 415b97b
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java a7b7553
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestHttpUrlConnection.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java 770dfb6
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java ce865cf
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java 99a2102
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java a03dfc7
Diff: https://reviews.apache.org/r/40110/diff/
Testing
-------
mvn clean test on ambari-metrics.
Manual testing done.
Added unit test to cover this case.
Thanks,
Aravindan Vijayan
Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/#review106503
-----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java (line 27)
<https://reviews.apache.org/r/40110/#comment165204>
Unintended change?
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java (line 59)
<https://reviews.apache.org/r/40110/#comment165205>
formatting
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java (line 96)
<https://reviews.apache.org/r/40110/#comment165206>
Should probaby ignore only Socket timeout from getting logged, otehr erros should be logged.
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java (line 334)
<https://reviews.apache.org/r/40110/#comment165207>
unintended change?
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line 917)
<https://reviews.apache.org/r/40110/#comment165208>
formatting
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java (line 751)
<https://reviews.apache.org/r/40110/#comment165209>
formatting
- Sid Wagle
On Nov. 13, 2015, 9:28 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40110/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 9:28 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-13798
> https://issues.apache.org/jira/browse/AMBARI-13798
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path.
>
> Also change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was. This log statements must be available on ambari-server.log as well.
>
> To make sure that ambari-server prints out the error, I had needed to change the way we read from the StreamProvider and read the error stream from the HttpUrlConnection. Specifically, the StreamProvider interface was changed to URLStreamProvider in all Metrics Property provider classes and tests.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java 640604d
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 2ef0a8e
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8b15569
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java ad35444
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java fb74fab
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java 54857cc
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java 9b23686
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaComponentPropertyProvider.java e531dff
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostComponentPropertyProvider.java 5508cbe
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java 41a500f
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java d2dbb11
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java cc0219c
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java 0e71049
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java 85e016f
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 2af7452
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 8b60c50
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java ca20e54
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java 9100afd
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java beffa9e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 415b97b
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java a7b7553
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestHttpUrlConnection.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java 770dfb6
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java ce865cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java 99a2102
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java a03dfc7
>
> Diff: https://reviews.apache.org/r/40110/diff/
>
>
> Testing
> -------
>
> mvn clean test on ambari-metrics.
>
> Manual testing done.
>
> Added unit test to cover this case.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>
Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 9:28 p.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-13798
https://issues.apache.org/jira/browse/AMBARI-13798
Repository: ambari
Description (updated)
-------
The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path.
Also change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was. This log statements must be available on ambari-server.log as well.
To make sure that ambari-server prints out the error, I had needed to change the way we read from the StreamProvider and read the error stream from the HttpUrlConnection. Specifically, the StreamProvider interface was changed to URLStreamProvider in all Metrics Property provider classes and tests.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestClusterSuite.java 640604d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java 2ef0a8e
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java 8b15569
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java ad35444
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProviderProxy.java fb74fab
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProvider.java 54857cc
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsReportPropertyProviderProxy.java 9b23686
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaComponentPropertyProvider.java e531dff
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostComponentPropertyProvider.java 5508cbe
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaHostPropertyProvider.java 41a500f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaPropertyProvider.java d2dbb11
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSComponentPropertyProvider.java cc0219c
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostComponentPropertyProvider.java 0e71049
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSHostPropertyProvider.java 85e016f
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 2af7452
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java 8b60c50
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java ca20e54
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java 9100afd
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java beffa9e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProviderTest.java 415b97b
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/TestStreamProvider.java a7b7553
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestHttpUrlConnection.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/TestStreamProvider.java 770dfb6
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java ce865cf
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProviderTest.java 99a2102
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java a03dfc7
Diff: https://reviews.apache.org/r/40110/diff/
Testing
-------
mvn clean test on ambari-metrics.
Manual testing done.
Added unit test to cover this case.
Thanks,
Aravindan Vijayan
Re: Review Request 40110: AMBARI-13798 Add ams-site resultset limit
property to upgrade
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40110/
-----------------------------------------------------------
(Updated Nov. 9, 2015, 11:41 p.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Changes
-------
Added old limit property to unit test.
Bugs: AMBARI-13798
https://issues.apache.org/jira/browse/AMBARI-13798
Repository: ambari
Description
-------
The AMS result set size property was recently changed through AMBARI-13411. This bug addresses the corresponding change to the upgrade path. Change log statements with respect to result limit exceeded failures to make sure they convey what the limit vs requested size was.
Diffs (updated)
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java 92d59e2
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3211b36
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 521dede
Diff: https://reviews.apache.org/r/40110/diff/
Testing
-------
mvn clean test on ambari-metrics.
Manual testing done.
Added unit test to cover this case.
Thanks,
Aravindan Vijayan