You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/01/17 22:05:04 UTC

Review Request 65196: Removed workaround in ZooKeeper test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65196/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Jeff Coffler, and Joseph Wu.


Bugs: MESOS-7803
    https://issues.apache.org/jira/browse/MESOS-7803


Repository: mesos


Description
-------

Now that `fs::list` returns the full path, this code can be fixed.


Diffs
-----

  src/tests/zookeeper.cpp 54cf9c63878b5b6d30df27838244eec46312d917 


Diff: https://reviews.apache.org/r/65196/diff/1/


Testing
-------

This was fixed while enabling recovery for the Windows agent.


Thanks,

Andrew Schwartzmeyer


Re: Review Request 65196: Removed workaround in ZooKeeper test.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65196/#review195661
-----------------------------------------------------------



PASS: Mesos patch 65196 was successfully built and tested.

Reviews applied: `['65195', '65196']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65196

- Mesos Reviewbot Windows


On Jan. 17, 2018, 10:05 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65196/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 10:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-7803
>     https://issues.apache.org/jira/browse/MESOS-7803
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now that `fs::list` returns the full path, this code can be fixed.
> 
> 
> Diffs
> -----
> 
>   src/tests/zookeeper.cpp 54cf9c63878b5b6d30df27838244eec46312d917 
> 
> 
> Diff: https://reviews.apache.org/r/65196/diff/1/
> 
> 
> Testing
> -------
> 
> This was fixed while enabling recovery for the Windows agent.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>