You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/06/28 20:28:48 UTC
[GitHub] [iceberg-docs] samredai opened a new pull request, #101: Add Impala to config defined docs menu
samredai opened a new pull request, #101:
URL: https://github.com/apache/iceberg-docs/pull/101
The recent iceberg-theme that was merged uses a Hugo config based menu. This adds the external link to the Impala docs. Since logos are no longer being used, this also removes the impala logo image from the repo.
cc: @pvary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] pvary merged pull request #101: Add Impala to config defined docs menu
Posted by GitBox <gi...@apache.org>.
pvary merged PR #101:
URL: https://github.com/apache/iceberg-docs/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] pvary commented on pull request #101: Add Impala to config defined docs menu
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #101:
URL: https://github.com/apache/iceberg-docs/pull/101#issuecomment-1169229258
That's cool.
Maybe a link in the main menu would be good, somewhere between Presto, Trinto and Impala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] pvary commented on pull request #101: Add Impala to config defined docs menu
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #101:
URL: https://github.com/apache/iceberg-docs/pull/101#issuecomment-1169210753
@samredai: Shall we add a Hive menu item as well?
Also this seems off:
```
{ name = "Presto", url = "../../how-to-release" , weight = 500 },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on pull request #101: Add Impala to config defined docs menu
Posted by GitBox <gi...@apache.org>.
samredai commented on PR #101:
URL: https://github.com/apache/iceberg-docs/pull/101#issuecomment-1169217756
@pvary with respect to adding Hive, that actually has its own internal page so when [hive.md](https://github.com/apache/iceberg/blob/master/docs/hive.md) is copied over from the iceberg repo, it will automatically show up as an item in the leftnav. (Set by the `menu: main` in the front matter)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on pull request #101: Add Impala to config defined docs menu
Posted by GitBox <gi...@apache.org>.
samredai commented on PR #101:
URL: https://github.com/apache/iceberg-docs/pull/101#issuecomment-1169211993
@pvary yes and yes, thanks for catching that! Opening a PR now 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org