You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/12/16 09:26:54 UTC
[GitHub] RongtongJin opened a new issue #608: Polish the whole example module
RongtongJin opened a new issue #608: Polish the whole example module
URL: https://github.com/apache/rocketmq/issues/608
**BUG REPORT**
1. Please describe the issue you observed:
There are some problems with the current example module:
- **Some legacy code no longer matches the current function**.
For example, RocketMQ had removed filterserv module since 4.3.x, but there is still filterserv example in source code. [issue590](https://github.com/apache/rocketmq/issues/590#issue-388918548)
- **There are some bugs in the some examples**.
https://github.com/apache/rocketmq/blob/d4d02b5e017ebf8c7d3405516264645280cf57fa/example/src/main/java/org/apache/rocketmq/example/filter/SqlConsumer.java#L36-L37
Missing “and” in SQL statement
https://github.com/apache/rocketmq/blob/d4d02b5e017ebf8c7d3405516264645280cf57fa/example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java#L33-L35
ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET make setConsumeTimestamp invalid
- **Some examples can be polished to make users better understand how to use RocketMQ.**
We can remove some useless examples, add new examples, add code comments, optimize code quality, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services