You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2013/08/22 19:55:59 UTC

[2/3] git commit: Fixed slave recovery tests to use 'strict' option by default.

Fixed slave recovery tests to use 'strict' option by default.

Review: https://reviews.apache.org/r/13676


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/514f0406
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/514f0406
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/514f0406

Branch: refs/heads/master
Commit: 514f04063010c2eefd0a0b804259aca645754a5c
Parents: 212fbb2
Author: Vinod Kone <vi...@twitter.com>
Authored: Mon Aug 19 17:14:15 2013 -0700
Committer: Vinod Kone <vi...@twitter.com>
Committed: Wed Aug 21 21:44:23 2013 -0700

----------------------------------------------------------------------
 src/tests/slave_recovery_tests.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/514f0406/src/tests/slave_recovery_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/slave_recovery_tests.cpp b/src/tests/slave_recovery_tests.cpp
index 3147860..830af59 100644
--- a/src/tests/slave_recovery_tests.cpp
+++ b/src/tests/slave_recovery_tests.cpp
@@ -128,7 +128,7 @@ public:
     // Setup recovery slave flags.
     flags.checkpoint = true;
     flags.recover = "reconnect";
-    flags.strict = false;
+    flags.strict = true;
 
     return flags;
   }
@@ -1190,8 +1190,9 @@ TYPED_TEST(SlaveRecoveryTest, KillTask)
 
 
 // When the slave is down we remove the "latest" symlink in the
-// executor's run directory, to simulate a situation where the slave
-// cannot recover the executor and hence schedules it for gc.
+// executor's run directory, to simulate a situation where the
+// recovered slave (--no-strict) cannot recover the executor and
+// hence schedules it for gc.
 TYPED_TEST(SlaveRecoveryTest, GCExecutor)
 {
   Try<PID<Master> > master = this->StartMaster();
@@ -1200,6 +1201,7 @@ TYPED_TEST(SlaveRecoveryTest, GCExecutor)
   TypeParam isolator1;
 
   slave::Flags flags = this->CreateSlaveFlags();
+  flags.strict = false;
 
   Try<PID<Slave> > slave = this->StartSlave(&isolator1, flags);
   ASSERT_SOME(slave);