[jira] [Commented] (MCHECKSTYLE-307) Upgrade to Checkstyle 6.9

["Robert Scholte (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727217#comment-14727217 ] 

Robert Scholte commented on MCHECKSTYLE-307:
--------------------------------------------

IIRC this issue has nothing to do with the location of the checkstyle rules, so either add a custom one ( e.g. {{src/config/sun_checks.xml}}) or go for inline config. Not sure which rules are really used for this test, should be easy to figure out.

> Upgrade to Checkstyle 6.9
> -------------------------
>
>                 Key: MCHECKSTYLE-307
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-307
>             Project: Maven Checkstyle Plugin
>          Issue Type: Task
>    Affects Versions: 2.16
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>
> Hi folks,
> I have upraded Checkstyle locally and almost all ITs pass except for the issues [~dennisl@apache.org] already has described:
> {quote}
> Changes in Checkstyle 6.3 that impact this plugin:
> * The IT MCHECKSTYLE-214-basedir-resource fails after upgrade to Checkstyle 6.3 with NPE - I have not found a solution for this yet
> Changes in Checkstyle 6.6 that impact this plugin:
> * DefaultLogger( OutputStream, boolean ) now throws UnsupportedEncodingException - this is easy to fix
> {quote}
> The first issue is caused because the default checkfiles apply to specific file extensions now, so IT for MCHECKSTYLE-214. [~rfscholte], what do you think about it. We can invert the test or add a custom {{sun_checks.xml}}.
> The second one can be fixed with the linked GH issue.
> I am willing to promote a release if I get some help to resolve the issues above.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)