You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@joshua.apache.org by thammegowda <gi...@git.apache.org> on 2017/10/25 20:33:49 UTC

[GitHub] incubator-joshua pull request #80: Code Reformatting and output of string le...

GitHub user thammegowda opened a pull request:

    https://github.com/apache/incubator-joshua/pull/80

    Code Reformatting and output of string length ratios

    one new number in the eval output - sentence length (number of words) ratios between output and reference.
    
    However, to interpret the existing code, I had to indent the code correctly.
    There are a lot of edits, but most of them are due to code reformatting - no functional change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thammegowda/incubator-joshua code-clean

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-joshua/pull/80.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #80
    
----
commit 36e3a5d39702e2f139afa7f0bd67220beef4cfa5
Author: Thamme Gowda <tg...@isi.edu>
Date:   2017-10-25T18:46:28Z

    code clean and reformat

commit 7eae36dbae9fe64ef929800cb7160e3739f16f77
Author: Thamme Gowda <tg...@isi.edu>
Date:   2017-10-25T19:03:06Z

    Output Ratio of Lengths of Strings

----


---

[GitHub] incubator-joshua pull request #80: Code Reformatting and output of string le...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-joshua/pull/80


---

[GitHub] incubator-joshua issue #80: Code Reformatting and output of string length ra...

Posted by tteofili <gi...@git.apache.org>.

Github user tteofili commented on the issue:

    https://github.com/apache/incubator-joshua/pull/80
  
    thanks @thammegowda your PR has been merged


---

[GitHub] incubator-joshua issue #80: Code Reformatting and output of string length ra...

Posted by thammegowda <gi...@git.apache.org>.

Github user thammegowda commented on the issue:

    https://github.com/apache/incubator-joshua/pull/80
  
    There are two commits. 
    
    The first one is for reformatting the code change.
    The second one is for computing the length ratios...


---