[GitHub] khos2ow commented on a change in pull request #2433: Fix and enhance package script

[GitBox <gi...@apache.org>]

khos2ow commented on a change in pull request #2433: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r165086511
 
 

 ##########
 File path: packaging/package.sh
 ##########
 @@ -67,22 +75,32 @@ function packaging() {
             exit 2
         fi
     fi
+
     VERSION=$(cd ../; $MVN org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version | grep --color=none '^[0-9]\.')
+    BASEVER=$(echo "$VERSION" | sed 's/-SNAPSHOT//g')
 
 Review comment:
   on this line I'm trying to get BRANDING string and not removing SNAPSHOT from final package name. That's don in line 94 and 97 (`$(date +%s)` instead of `SNAPSHOT`).
   And I believe this will be a good change because it will prevent accidental artifacts overridden on top of each other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services