You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Mohamed Battisha (Created) (JIRA)" <ji...@apache.org> on 2012/02/27 20:12:47 UTC
[jira] [Created] (OOZIE-719) Follow up on OOZIEE-687: Missing java
docs for several methods on ActionXCommand.java
Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java
---------------------------------------------------------------------------------------
Key: OOZIE-719
URL: https://issues.apache.org/jira/browse/OOZIE-719
Project: Oozie
Issue Type: Improvement
Reporter: Mohamed Battisha
Priority: Trivial
adding java docs for several ActionXCommand.java.
Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-719) Follow up on OOZIEE-687: Missing
java docs for several methods on ActionXCommand.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223803#comment-13223803 ]
jiraposter@reviews.apache.org commented on OOZIE-719:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/#review5668
-----------------------------------------------------------
Ship it!
+1
- Mohammad
On 2012-03-03 20:59:54, Mohamed Battisha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4072/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-03 20:59:54)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Missing java docs for several methods on ActionXCommand.java
bq.
bq.
bq. This addresses bug OOZIE-719.
bq. https://issues.apache.org/jira/browse/OOZIE-719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1296701
bq.
bq. Diff: https://reviews.apache.org/r/4072/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. no code changes only documentation
bq.
bq.
bq. Thanks,
bq.
bq. Mohamed
bq.
bq.
> Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java
> ---------------------------------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-719) Missing java docs for several methods
on ActionXCommand.java
Posted by "Alejandro Abdelnur (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur resolved OOZIE-719.
--------------------------------------
Resolution: Fixed
Fix Version/s: 3.2.0
Assignee: Mohamed Battisha
thanks Mohamed. Committed to trunk by Mohammad
> Missing java docs for several methods on ActionXCommand.java
> --------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Assignee: Mohamed Battisha
> Priority: Trivial
> Fix For: 3.2.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-719) Follow up on OOZIEE-687: Missing
java docs for several methods on ActionXCommand.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222501#comment-13222501 ]
jiraposter@reviews.apache.org commented on OOZIE-719:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/#review5616
-----------------------------------------------------------
Ship it!
- Virag
On 2012-03-03 20:59:54, Mohamed Battisha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4072/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-03 20:59:54)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Missing java docs for several methods on ActionXCommand.java
bq.
bq.
bq. This addresses bug OOZIE-719.
bq. https://issues.apache.org/jira/browse/OOZIE-719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1296701
bq.
bq. Diff: https://reviews.apache.org/r/4072/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. no code changes only documentation
bq.
bq.
bq. Thanks,
bq.
bq. Mohamed
bq.
bq.
> Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java
> ---------------------------------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-719) Follow up on OOZIEE-687: Missing
java docs for several methods on ActionXCommand.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221697#comment-13221697 ]
jiraposter@reviews.apache.org commented on OOZIE-719:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/
-----------------------------------------------------------
(Updated 2012-03-03 20:59:54.960684)
Review request for oozie.
Changes
-------
adding javadocs for protected member as well
Summary
-------
Missing java docs for several methods on ActionXCommand.java
This addresses bug OOZIE-719.
https://issues.apache.org/jira/browse/OOZIE-719
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1296701
Diff: https://reviews.apache.org/r/4072/diff
Testing
-------
no code changes only documentation
Thanks,
Mohamed
> Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java
> ---------------------------------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-719) Follow up on OOZIEE-687: Missing
java docs for several methods on ActionXCommand.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220201#comment-13220201 ]
jiraposter@reviews.apache.org commented on OOZIE-719:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Missing java docs for several methods on ActionXCommand.java
This addresses bug OOZIE-719.
https://issues.apache.org/jira/browse/OOZIE-719
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1295701
Diff: https://reviews.apache.org/r/4072/diff
Testing
-------
no code changes only documentation
Thanks,
Mohamed
> Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java
> ---------------------------------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-719) Follow up on OOZIEE-687: Missing
java docs for several methods on ActionXCommand.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220624#comment-13220624 ]
jiraposter@reviews.apache.org commented on OOZIE-719:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4072/#review5537
-----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11958>
Is the indentation incorrect or its just the way how it appears here?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11959>
Its better to have javadoc for protected methods also
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11960>
/**
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/4072/#comment11961>
/**
- Virag
On 2012-03-01 18:13:53, Mohamed Battisha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4072/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-01 18:13:53)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Missing java docs for several methods on ActionXCommand.java
bq.
bq.
bq. This addresses bug OOZIE-719.
bq. https://issues.apache.org/jira/browse/OOZIE-719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1295701
bq.
bq. Diff: https://reviews.apache.org/r/4072/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. no code changes only documentation
bq.
bq.
bq. Thanks,
bq.
bq. Mohamed
bq.
bq.
> Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java
> ---------------------------------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Priority: Trivial
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-719) Missing java docs for several methods
on ActionXCommand.java
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated OOZIE-719:
-------------------------------------
Summary: Missing java docs for several methods on ActionXCommand.java (was: Follow up on OOZIEE-687: Missing java docs for several methods on ActionXCommand.java )
> Missing java docs for several methods on ActionXCommand.java
> --------------------------------------------------------------
>
> Key: OOZIE-719
> URL: https://issues.apache.org/jira/browse/OOZIE-719
> Project: Oozie
> Issue Type: Improvement
> Reporter: Mohamed Battisha
> Priority: Trivial
> Fix For: 3.2.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> adding java docs for several ActionXCommand.java.
> Making sure it is consistent across the different methods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira