[jira] [Commented] (BEAM-9240) Check for Nullability in typesEqual() method of FieldType class

["Rui Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-9240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043971#comment-17043971 ] 

Rui Wang commented on BEAM-9240:
--------------------------------

I am going to cut 2.20.0 branch on 02/26/2020. Can this Jira be finished by that date? Will you able to push this back to 2.21.0?

> Check for Nullability in typesEqual() method of FieldType class
> ---------------------------------------------------------------
>
>                 Key: BEAM-9240
>                 URL: https://issues.apache.org/jira/browse/BEAM-9240
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>    Affects Versions: 2.18.0
>            Reporter: Rahul Patwari
>            Assignee: Rahul Patwari
>            Priority: Major
>             Fix For: 2.20.0
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> {{If two schemas are created like this:}}
> {{Schema schema1 = Schema.builder().addStringField("col1").build();}}
>  {{Schema schema2 = Schema.builder().addNullableField("col1", FieldType.STRING).build();}}
>  
> {{schema1.typeEquals(schema2) returns "true" even though the schemas differ by Nullability}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)