You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "VGalaxies (via GitHub)" <gi...@apache.org> on 2023/08/07 02:45:54 UTC
[GitHub] [incubator-hugegraph] VGalaxies opened a new pull request, #2270: refact: merge pd into hugegraph
VGalaxies opened a new pull request, #2270:
URL: https://github.com/apache/incubator-hugegraph/pull/2270
## Purpose of the PR
subtask of https://github.com/apache/incubator-hugegraph/issues/2265
Merge the internal version of pd into hugegraph.
<!--
Please explain more context in this section, clarify why the changes are needed.
e.g:
- If you propose a new API, clarify the use case for a new API.
- If you fix a bug, you can clarify why it is a bug, and should be associated with an issue.
-->
## Main Changes
1. Merge the internal version of pd into `hugegraph-pd` module.
2. Modified some pom files under the `hugegraph-pd` module so that it can be built normally **under certain conditions**.
3. Remove or annotate some sensitive information in `hugegraph-pd`.
NOTE:
1. Due to the modification of `<parent>` in the root pom of `hugegraph-pd` from `spring-boot-starter-parent` to `hugegraph`, it is necessary to explicitly specify the version of some dependencies for the `hugegraph-pd` submodules.
2. To ensure compatibility with Java 8, the maven compiler version in `hugegraph-pd` has been set to 1.8. However, there are still some features in the code (such as the `var` keyword) that are specific to higher Java versions **(TODO)**.
<!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. These change logs are helpful for better ant faster reviews.)
For example:
- If you introduce a new feature, please show detailed design here or add the link of design documentation.
- If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
- If there is a discussion in the mailing list, please add the link. -->
## Verifying these changes
<!-- Please pick the proper options below -->
- [ ] Trivial rework / code cleanup without any test coverage. (No Need)
- [ ] Already covered by existing tests, such as *(please modify tests here)*.
- [x] Need tests and can be verified as follows:
- subsequent PRs will merge store and more adaptation work needs to be done
## Does this PR potentially affect the following parts?
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] Nope
- [ ] Dependencies (add/update license info) <!-- Don't forget to add/update the info in "LICENSE" & "NOTICE" files (both in root & dist module) -->
- [ ] Modify configurations
- [ ] The public API
- [x] Other affects (breaking changes)
## Documentation Status
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `Doc - TODO` <!-- Your PR changes impact docs and you will update later -->
- [ ] `Doc - Done` <!-- Related docs have been already added or updated -->
- [ ] `Doc - No Need` <!-- Your PR changes don't impact/need docs -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] VGalaxies commented on a diff in pull request #2270: refact: merge pd into hugegraph
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2270:
URL: https://github.com/apache/incubator-hugegraph/pull/2270#discussion_r1285348108
##########
hugegraph-pd/hg-pd-service/src/main/resources/public-certs.store:
##########
Review Comment:
@imbajin ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin merged pull request #2270: refact: merge pd into hugegraph
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin merged PR #2270:
URL: https://github.com/apache/incubator-hugegraph/pull/2270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] VGalaxies commented on a diff in pull request #2270: refact: merge pd into hugegraph
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #2270:
URL: https://github.com/apache/incubator-hugegraph/pull/2270#discussion_r1285347646
##########
hugegraph-pd/hg-pd-service/src/main/resources/private-keys.store:
##########
Review Comment:
@imbajin Does this file need to be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2270: refact: merge pd into hugegraph
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2270:
URL: https://github.com/apache/incubator-hugegraph/pull/2270#discussion_r1285489433
##########
hugegraph-pd/hg-pd-service/src/main/resources/public-certs.store:
##########
Review Comment:
> @imbajin ditto
same, we don't need license(related) files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph] imbajin commented on a diff in pull request #2270: refact: merge pd into hugegraph
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #2270:
URL: https://github.com/apache/incubator-hugegraph/pull/2270#discussion_r1285488834
##########
hugegraph-pd/hg-pd-service/src/main/resources/private-keys.store:
##########
Review Comment:
> @imbajin Does this file need to be used?
Nope, could check the reference & safe remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org