You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by davemssavage <gi...@git.apache.org> on 2018/10/12 15:19:45 UTC
[GitHub] nifi pull request #3068: NIFI-5693 add support for multiple attachments in P...
GitHub user davemssavage opened a pull request:
https://github.com/apache/nifi/pull/3068
NIFI-5693 add support for multiple attachments in PutEmail via optional property
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davemssavage/nifi NIFI-5693-putemail-attachments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3068
----
commit ec92185f4cb416bf47da3317d105e2fb9112c765
Author: David Savage <da...@...>
Date: 2018-10-12T15:17:59Z
add support for multiple attachments in PutEmail via optional property
----
---
[GitHub] nifi issue #3068: NIFI-5693 add support for multiple attachments in PutEmail...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/3068
No rush, but am ready to review it whenever your ready.
---
[GitHub] nifi issue #3068: NIFI-5693 add support for multiple attachments in PutEmail...
Posted by davemssavage <gi...@git.apache.org>.
Github user davemssavage commented on the issue:
https://github.com/apache/nifi/pull/3068
Great, I was thinking it would make sense to support all the types that MergeContent supports, however I didn't want to go down that route till others had a chance to comment on the options. I'll take a look at the other formats and submit an update soon with an updated description and more input format options
---
[GitHub] nifi issue #3068: NIFI-5693 add support for multiple attachments in PutEmail...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/3068
I like your #2 approach, as shown in this PR. I haven't tested it yet, but can you provide a better description on the property? Right now there is no way for a user to know that TAR is the expected merge format (instead of, for example, the NiFi FlowFile packing format)
---