You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "rluvaton (via GitHub)" <gi...@apache.org> on 2026/04/06 14:59:43 UTC
[I] Automate breaking change detection [datafusion]
rluvaton opened a new issue, #21406:
URL: https://github.com/apache/datafusion/issues/21406
### Is your feature request related to a problem or challenge?
I've just upgraded from datafusion 51 to 52 and now from 52 to 53, and in both cases not all breaking changes were listed in the upgrade guide which makes me dig the original change and understand it and what was before in order to update
### Describe the solution you'd like
If we could have a GitHub action that track breaking changes (not behavior ones) and mark them with a label as a start.
Since clippy already know if the function is really public or not (like `pub(crate) mod a { pub mod b { } }` `mod b` is not really public we can use that somehow to check whether a change that was made in each pr is a breaking change regarding, and we can output a report of each breaking change in the pr, (like removed function a, b. added to trait function c with no default implementation, added argument to a function, changed visibility)
### Describe alternatives you've considered
Pain when I upgrade to encounter it myself
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Automate breaking change detection [datafusion]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton commented on issue #21406:
URL: https://github.com/apache/datafusion/issues/21406#issuecomment-4445163056
Marking this as closed as this is mainly done in:
- #21499
Although it only detect api breaking changes and not behavior, but having behavior is much much harder to do reliably.
Also, from what I see this is a huge success since many prs that say that there are no breaking changes do include breaking change.
maybe we should add it to `arrow-rs` as well if interested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Automate breaking change detection [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on issue #21406:
URL: https://github.com/apache/datafusion/issues/21406#issuecomment-4199943348
I agree, LLM can help generate Upgrade Guide section, we already have a definition for breaking changes, as well as `generate-changelog.py` collects them by `api-change` Github tag. If we can feed those PRs to LLM asking for a concise upgrade summary, it might work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Automate breaking change detection [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #21406:
URL: https://github.com/apache/datafusion/issues/21406#issuecomment-4257518809
fyi existing issue
- https://github.com/apache/datafusion/issues/13665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Automate breaking change detection [datafusion]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton commented on issue #21406:
URL: https://github.com/apache/datafusion/issues/21406#issuecomment-4192961417
We could also force each breaking change PR to write a migration guide and in the release it is just a matter of collecting all of that migration guide files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Automate breaking change detection [datafusion]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton commented on issue #21406:
URL: https://github.com/apache/datafusion/issues/21406#issuecomment-4208930725
I think it should be up to the author of the breaking change
But to force PRs that make a breaking change to also include a couple of sentences is a good idea IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Automate breaking change detection [datafusion]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton closed issue #21406: Automate breaking change detection
URL: https://github.com/apache/datafusion/issues/21406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org