You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/26 00:29:26 UTC

[GitHub] [beam] ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics.

ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics.
URL: https://github.com/apache/beam/pull/11213#issuecomment-604159640
 
 
   > Could you elaborate on why this change is needed?
   
   @kamilwu Check out the [jira](https://issues.apache.org/jira/browse/BEAM-9214). The current code assumes the `context` argument is optional, but the generated code in the default implementation requires it, meaning instead of getting the correct error (`NotImplementedError`) I was getting a confusing `TypeError`. I will fix that underlying issue in a different PR, however we should change this code so that it provides the proper error message to the next person who runs into it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services