You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Zheng Feng (Jira)" <ji...@apache.org> on 2023/02/13 07:45:00 UTC

[jira] [Commented] (CAMEL-19031) When camel saga do compensated, the saga route don't stop it still run the next task.

    [ https://issues.apache.org/jira/browse/CAMEL-19031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687777#comment-17687777 ] 

Zheng Feng commented on CAMEL-19031:
------------------------------------

It seems that InMemorySagaCoordinator::beginStep does not check the current status. So even the status is not *RUNNING*, it still add the step. Then a potential fix could be to add a status checking. I create a patch as an attachement, [~chen19980] can you verify it? [^InMemorySagaCoordinator.patch] 

> When camel saga do compensated, the saga route don't stop it still run the next task.
> -------------------------------------------------------------------------------------
>
>                 Key: CAMEL-19031
>                 URL: https://issues.apache.org/jira/browse/CAMEL-19031
>             Project: Camel
>          Issue Type: Bug
>    Affects Versions: 3.19.0
>            Reporter: adam chen
>            Assignee: Zheng Feng
>            Priority: Major
>         Attachments: InMemorySagaCoordinator.patch, RouteCode.jpg, SagaTest.jpg
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> The problem is : I find that when actionA is timeout and it executed compensated, In theory the saga route should be stopped, not continue to call the next actionB.  In my test show that when {color:#ff0000}the first task can't complete before its timeout, it will run compensation but the saga route don't stop, it still run second task and third task{color}. In my opinion, I think when the first task can't complete and run compensation, the second and third task shouldn't run.  [Test Code|[https://github.com/chen19980/SAGA_timeout_test]]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)