You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Anand V Nath (JIRA)" <de...@myfaces.apache.org> on 2012/05/08 08:04:18 UTC
[jira] [Commented] (TRINIDAD-2063) generated css file includes
selectors with {}
[ https://issues.apache.org/jira/browse/TRINIDAD-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270231#comment-13270231 ]
Anand V Nath commented on TRINIDAD-2063:
----------------------------------------
bug-13003991.patch is the patch for http://svn.apache.org/repos/asf/myfaces/trinidad/branches/1.2.12.7.0-branch
> generated css file includes selectors with {}
> ---------------------------------------------
>
> Key: TRINIDAD-2063
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2063
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 2.0.0-beta-2
> Reporter: Jeanne Waldman
> Assignee: Jeanne Waldman
> Fix For: 2.0.0-core
>
> Attachments: bug-13003991.patch
>
>
> If a selector has skinning properties only, like af|foo {-tr-some-property: true}, then this gets placed into the css file like
> af|foo {}.
> And if it is compact mode, it will get into the css file like:
> . {} It won't have a compressed value, like .x10, because it is considered empty and the skinning framework does not give a compressed value to empty keys.
> If you have a css file with a lot of selectors that have only skin-properties, then your generated css file could look like:
> ., ., ., ., ., ., ., ., ., {}
> --
> The fix is in CSSGenerationUtils.java do not output selectors with an empty property string.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (TRINIDAD-2063) generated css file includes
selectors with {}
Posted by Anand Nath <an...@oracle.com>.
Hello,
Please review and commit this patch.
Thanks
Anand
On 5/8/2012 11:34 AM, Anand V Nath (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/TRINIDAD-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270231#comment-13270231 ]
>
> Anand V Nath commented on TRINIDAD-2063:
> ----------------------------------------
>
> bug-13003991.patch is the patch for http://svn.apache.org/repos/asf/myfaces/trinidad/branches/1.2.12.7.0-branch
>
>
>> generated css file includes selectors with {}
>> ---------------------------------------------
>>
>> Key: TRINIDAD-2063
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-2063
>> Project: MyFaces Trinidad
>> Issue Type: Bug
>> Components: Skinning
>> Affects Versions: 2.0.0-beta-2
>> Reporter: Jeanne Waldman
>> Assignee: Jeanne Waldman
>> Fix For: 2.0.0-core
>>
>> Attachments: bug-13003991.patch
>>
>>
>> If a selector has skinning properties only, like af|foo {-tr-some-property: true}, then this gets placed into the css file like
>> af|foo {}.
>> And if it is compact mode, it will get into the css file like:
>> . {} It won't have a compressed value, like .x10, because it is considered empty and the skinning framework does not give a compressed value to empty keys.
>> If you have a css file with a lot of selectors that have only skin-properties, then your generated css file could look like:
>> ., ., ., ., ., ., ., ., ., {}
>> --
>> The fix is in CSSGenerationUtils.java do not output selectors with an empty property string.
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>