You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/14 13:21:25 UTC

[GitHub] [flink-connector-rabbitmq] smulikHakipod opened a new pull request, #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

smulikHakipod opened a new pull request, #4:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/4

   Related to https://github.com/apache/flink/pull/21509
   
   Jira: 
   
   https://issues.apache.org/jira/browse/FLINK-30417
   
   ## What is the purpose of the change
   
   To better describe the error of RabbitMQ connection failures.
   
   
   ## Brief change log
   
     -  Better error indication when we fail to connect to RabbitMQ
   
   
   ## Verifying this change
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no )
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-rabbitmq] boring-cyborg[bot] commented on pull request #4: Add "RabbitMQ" to the error while creating the channel and failing

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #4:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/4#issuecomment-1351342984

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-rabbitmq] MartijnVisser merged pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #4:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-rabbitmq] MartijnVisser commented on pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #4:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/4#issuecomment-1359531946

   @smulikHakipod Please follow https://flink.apache.org/contributing/how-to-contribute.html next time, specifically for your commit message layout. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-rabbitmq] smulikHakipod closed pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

Posted by GitBox <gi...@apache.org>.
smulikHakipod closed pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel 
URL: https://github.com/apache/flink-connector-rabbitmq/pull/4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-rabbitmq] boring-cyborg[bot] commented on pull request #4: [FLINK-30417] [Connectors/ RabbitMQ] add "RabbitMQ" to rabbit error while creating the channel

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #4:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/4#issuecomment-1359532519

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org