You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ze...@apache.org on 2024/10/07 15:16:56 UTC

(streampipes) branch hotfix-edit-correction-value-remove-unused-event-emitter created (now b1fb318426)

This is an automated email from the ASF dual-hosted git repository.

zehnder pushed a change to branch hotfix-edit-correction-value-remove-unused-event-emitter
in repository https://gitbox.apache.org/repos/asf/streampipes.git


      at b1fb318426 refactor: Remove unused event emitter

This branch includes the following new commits:

     new b1fb318426 refactor: Remove unused event emitter

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(streampipes) 01/01: refactor: Remove unused event emitter

Posted by ze...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

zehnder pushed a commit to branch hotfix-edit-correction-value-remove-unused-event-emitter
in repository https://gitbox.apache.org/repos/asf/streampipes.git

commit b1fb318426ba62c0f31871bcc1fbf743ea8e9ed6
Author: Philipp Zehnder <te...@users.noreply.github.com>
AuthorDate: Mon Oct 7 17:13:12 2024 +0200

    refactor: Remove unused event emitter
---
 .../edit-correction-value.component.html              |  2 --
 .../edit-correction-value.component.ts                | 19 +------------------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.html b/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.html
index a7435e21b7..921d1b536f 100644
--- a/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.html
+++ b/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.html
@@ -39,7 +39,6 @@
                     [(ngModel)]="
                         cachedProperty.additionalMetadata.correctionValue
                     "
-                    (change)="valueChanged()"
                     data-cy="connect-schema-correction-value"
                 />
             </mat-form-field>
@@ -50,7 +49,6 @@
                     required
                     placeholder="Math Operator"
                     [(ngModel)]="cachedProperty.additionalMetadata.operator"
-                    (selectionChange)="valueChanged()"
                     [disabled]="
                         !cachedProperty.additionalMetadata.correctionValue
                     "
diff --git a/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.ts b/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.ts
index 1b16d86c85..68b5abce1e 100644
--- a/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.ts
+++ b/ui/src/app/connect/dialog/edit-event-property/components/edit-value-transformation/edit-correction-value/edit-correction-value.component.ts
@@ -16,7 +16,7 @@
  *
  */
 
-import { Component, EventEmitter, Input, Output } from '@angular/core';
+import { Component, Input } from '@angular/core';
 import { EventPropertyUnion } from '@streampipes/platform-services';
 
 @Component({
@@ -27,27 +27,10 @@ import { EventPropertyUnion } from '@streampipes/platform-services';
 export class EditCorrectionValueComponent {
     @Input() cachedProperty: EventPropertyUnion;
 
-    @Output() correctionValueChanged = new EventEmitter<boolean>();
-
     operators = [
         { value: 'MULTIPLY', viewValue: 'Multiply' },
         { value: 'ADD', viewValue: 'Add' },
         { value: 'SUBTRACT', viewValue: 'Subtract' },
         { value: 'DIVIDE', viewValue: 'Divide' },
     ];
-
-    constructor() {}
-
-    valueChanged() {
-        if (this.cachedProperty.additionalMetadata.correctionValue) {
-            if (!this.cachedProperty.additionalMetadata.operator) {
-                this.correctionValueChanged.emit(true);
-            } else {
-                this.correctionValueChanged.emit(false);
-            }
-        } else {
-            this.correctionValueChanged.emit(false);
-            this.cachedProperty.additionalMetadata.operator = undefined;
-        }
-    }
 }