You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/07/07 10:40:49 UTC
Re: Review Request 30032: Added support for cache control in
libprocess when dealing with static files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review90672
-----------------------------------------------------------
Ship it!
If/when RR 34703 ships first, please fix this TODO:
// TODO(arojas): Use Path.mtime() once it is available.
- Bernd Mathiske
On June 17, 2015, 8:42 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30032/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 8:42 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park, and Till Toenshoff.
>
>
> Bugs: mesos-708
> https://issues.apache.org/jira/browse/mesos-708
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When serving a static file, libprocess returns the header `Last-Modified` which is used by browsers to control Cache.
> When a http request arrives containing the header `If-Modified-Since`, a response `304 Not Modified` is returned if the date in the request and the modification time (as returned by doing `stat` in the file) coincide.
> Unit tests added.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417
> 3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6
> 3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058
>
> Diff: https://reviews.apache.org/r/30032/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>