[GitHub] [superset] rosemarie-chiu commented on pull request #17176: fix(AlertReportModal): Text Area Change

[GitBox <gi...@apache.org>]

rosemarie-chiu commented on pull request #17176:
URL: https://github.com/apache/superset/pull/17176#issuecomment-954959173


   @AAfghahi @eschutho I'm not sure if this is related to this fix, I found that I no longer able to see the query on the virtual dataset after this code change.
   
   Steps:
   1. In Sql editor, run a query and explore save as new dataset
   2. Check the sql on the dataset and not able to see anything
   3. Only able to see the query on that virutal dataset when clicking on view in sql lab
   
   
   https://user-images.githubusercontent.com/52086618/139484019-9767f5cf-a036-4460-88b1-b7adee54df52.mov
   
   
   I tested on other Ephemeral env and do not reproduce this, so I suspect it is caused by this PR.
   
   ✅ regression test creating new alert, edit alert sql editor field not overwrites
   ✅ regression test sql editor save query, update saved query, multiple query tab


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org