You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Mattias Engdegård <ma...@bredband.net> on 2013/05/01 01:47:58 UTC

Re: sqlite3.c won't compile with -std=c89

25 mar 2013 kl. 23.03 skrev Mattias Engdegård:

> [[[
> Work around a problem on older OS X systems: sqlite3.c includes
> <libkern/OSAtomic.h>, which uses 'inline' and thus cannot be compiled
> with -std=c89 that we are using for all files.
>
> * subversion/libsvn_subr/sqlite3wrapper.c
>  (toplevel): Define 'inline' as '__inline__' (which gcc accepts even  
> in c89
>   mode) during a pre-emptive inclusion of <libkern/OSAtomic.h>.
> * subversion/tests/libsvn_wc/wc-queries-test.c
>  (toplevel): Likewise.
> ]]]
>
> <apple.patch>

Would someone please apply, approve or reject this patch?

Re: sqlite3.c won't compile with -std=c89

Posted by Branko Čibej <br...@wandisco.com>.

On 01.05.2013 01:47, Mattias Engdegård wrote:
> 25 mar 2013 kl. 23.03 skrev Mattias Engdegård:
>
>> [[[
>> Work around a problem on older OS X systems: sqlite3.c includes
>> <libkern/OSAtomic.h>, which uses 'inline' and thus cannot be compiled
>> with -std=c89 that we are using for all files.
>>
>> * subversion/libsvn_subr/sqlite3wrapper.c
>>  (toplevel): Define 'inline' as '__inline__' (which gcc accepts even
>> in c89
>>   mode) during a pre-emptive inclusion of <libkern/OSAtomic.h>.
>> * subversion/tests/libsvn_wc/wc-queries-test.c
>>  (toplevel): Likewise.
>> ]]]
>>
>> <apple.patch>
>
> Would someone please apply, approve or reject this patch?

Thanks for the reminder. Committed in r1480149.

-- Brane


-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com