You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ZoeyeoZ (via GitHub)" <gi...@apache.org> on 2026/03/09 23:51:20 UTC
[PR] SPARK-53675: Add str support in withColumn and withColumn in PySpark [spark]
ZoeyeoZ opened a new pull request, #54708:
URL: https://github.com/apache/spark/pull/54708
Switch from Column to ColumnOrName, and reuse builtin function, which also have type check
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Add support for https://issues.apache.org/jira/browse/SPARK-53675
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
User will be able to use str and column for withColumn and withColumns. And we does change the error message from `NOT_COLUMN` to `NOT_COLUMN_OR_STR`
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Test `python/run-tests --testnames pyspark.sql.tests.test_dataframe`
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
Claude help me to understand the behaviors
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #54708:
URL: https://github.com/apache/spark/pull/54708#discussion_r2963423124
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1626,7 +1659,7 @@ def _ipython_key_completions_(self) -> List[str]:
"""
return self.columns
- def withColumns(self, *colsMap: Dict[str, Column]) -> ParentDataFrame:
+ def withColumns(self, *colsMap: Dict[str, "ColumnOrName"]) -> ParentDataFrame:
Review Comment:
You could do just `withColumns(..., col("name"))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4041066956
CC @devin-petersohn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4094589266
Yeah we'd want to do a follow on in the Scala side too post merge (happy to do that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4041066028
Did a quick grep looking for ColumnOrName and it seems like we're already using that type elsewhere so that looks good :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4086254524
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #54708:
URL: https://github.com/apache/spark/pull/54708#discussion_r2963422678
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1626,7 +1659,7 @@ def _ipython_key_completions_(self) -> List[str]:
"""
return self.columns
- def withColumns(self, *colsMap: Dict[str, Column]) -> ParentDataFrame:
+ def withColumns(self, *colsMap: Dict[str, "ColumnOrName"]) -> ParentDataFrame:
Review Comment:
Yeah, actually I think `withColumnRenamed` already exists which should do the similar thing. `withColumns` allows expressions with `Column` so I think it's a bit awkward to support column name here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4828135042
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #54708: [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark
URL: https://github.com/apache/spark/pull/54708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "ZoeyeoZ (via GitHub)" <gi...@apache.org>.
ZoeyeoZ commented on code in PR #54708:
URL: https://github.com/apache/spark/pull/54708#discussion_r2967779757
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1626,7 +1659,7 @@ def _ipython_key_completions_(self) -> List[str]:
"""
return self.columns
- def withColumns(self, *colsMap: Dict[str, Column]) -> ParentDataFrame:
+ def withColumns(self, *colsMap: Dict[str, "ColumnOrName"]) -> ParentDataFrame:
Review Comment:
got it, yeah i can switch to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4088087674
Oh, actually I misread the code. Scala side does not support this. Let's actually revert this. I merged this to be API parity but realised that we should take a look there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4086254438
Lets double check quickly with @HyukjinKwon if no concerns I can merge it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #54708:
URL: https://github.com/apache/spark/pull/54708#issuecomment-4087806463
Sorry for the late reply, I am fine to support str type in `withColumn` and `withColumns`, this PR treats str as column name, I feel it is kind of similar to what `withColumnRenamed` does.
I personally think it will make more sense if we can extend `str` as a function expression. e.g.
```
df.withColumn('agg_plus_1', 'age + 1').show()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #54708: [SPARK-53675][PYTHON] Add str support in withColumn and withColumns in PySpark
URL: https://github.com/apache/spark/pull/54708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org