You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/23 00:53:13 UTC
[GitHub] [incubator-doris] stalary opened a new pull request, #9728: [Bug] If function adds type inference
stalary opened a new pull request, #9728:
URL: https://github.com/apache/incubator-doris/pull/9728
# Proposed changes
Issue Number: close https://github.com/apache/incubator-doris/issues/9662
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9728: [Bug] If function adds type inference
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728#issuecomment-1134046031
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9728: [Bug] If function adds type inference
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728#issuecomment-1137433042
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on a diff in pull request #9728: [Bug] If function adds type inference
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728#discussion_r878971202
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##########
@@ -869,6 +869,11 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
childTypes[i] = children.get(i).type;
}
+ } else if (fnName.getFunction().equalsIgnoreCase("if")) {
+ Type[] childTypes = collectChildReturnTypes();
+ Type assignmentCompatibleType = ScalarType.getAssignmentCompatibleType(childTypes[1], childTypes[2], true);
+ childTypes[1] = assignmentCompatibleType;
+ childTypes[2] = assignmentCompatibleType;
fn = getBuiltinFunction(analyzer, fnName.getFunction(), childTypes,
Review Comment:
After this change, FunctionSet.WINDOW_FUNNEL will not call getBuiltinFunction any more.
It seams FunctionSet.WINDOW_FUNNEL will work not correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] stalary commented on a diff in pull request #9728: [Bug] If function adds type inference
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728#discussion_r879009771
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##########
@@ -869,6 +869,11 @@ public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
childTypes[i] = children.get(i).type;
}
+ } else if (fnName.getFunction().equalsIgnoreCase("if")) {
+ Type[] childTypes = collectChildReturnTypes();
+ Type assignmentCompatibleType = ScalarType.getAssignmentCompatibleType(childTypes[1], childTypes[2], true);
+ childTypes[1] = assignmentCompatibleType;
+ childTypes[2] = assignmentCompatibleType;
fn = getBuiltinFunction(analyzer, fnName.getFunction(), childTypes,
Review Comment:
My problem, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9728: [Bug] If function adds type inference
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9728: [Bug] If function adds type inference
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9728:
URL: https://github.com/apache/incubator-doris/pull/9728#issuecomment-1134046006
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org