You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/12/08 22:33:10 UTC

[GitHub] [solr] uschindler opened a new pull request #452: SOLR-15839: Don't mocj Sort class (why the hell was this needed?)

uschindler opened a new pull request #452:
URL: https://github.com/apache/solr/pull/452


   See https://issues.apache.org/jira/browse/SOLR-15839


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] uschindler commented on pull request #452: SOLR-15839: Don't mock oal.search.Sort class (why the hell was this needed?)

Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #452:
URL: https://github.com/apache/solr/pull/452#issuecomment-989284382


   Sneaky test passes:
   
   ```
   gradlew :solr:core:test --tests QueryComponentPartialResultsTest
   To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.2/userguide/gradle_daemon.html#sec:disabling_the_daemon.
   Daemon will be stopped at the end of the build
   
   > Task :randomizationInfo
   Running tests with randomization seed: tests.seed=AE79BECFA5AFD6B4
   
   > Task :solr:core:test
   :solr:core:test (SUCCESS): 4 test(s)
   The slowest suites (exceeding 1s) during this run:
      2.95s QueryComponentPartialResultsTest (:solr:core)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] uschindler commented on pull request #452: SOLR-15839: Don't mock oal.search.Sort class (why the hell was this needed?)

Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #452:
URL: https://github.com/apache/solr/pull/452#issuecomment-989282793


   This is a fishy, stinky, and SNEAKY thing to mock!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] uschindler merged pull request #452: SOLR-15839: Don't mock oal.search.Sort class (why the hell was this needed?)

Posted by GitBox <gi...@apache.org>.
uschindler merged pull request #452:
URL: https://github.com/apache/solr/pull/452


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org